Skip to content

feat(kellnr): configure additional OAuth2 audiences - #93

Merged
secana merged 2 commits into
kellnr:mainfrom
Moderny:feat/oidc-additional-audiences
Sep 1, 2026
Merged

feat(kellnr): configure additional OAuth2 audiences#93
secana merged 2 commits into
kellnr:mainfrom
Moderny:feat/oidc-additional-audiences

Conversation

@moderny-it

@moderny-it moderny-it commented Aug 30, 2026

Copy link
Copy Markdown

Hey, while trying out kellnr with my IdP (Zitadel) I saw it sending multiple aud in the token during oauth2 and kellnr right now need the aud to only have the clientId in aud.

With the related PR for kellnr and this PR, it allows it to accept "extra" aud.

kellnr PR : kellnr/kellnr#1357

secana pushed a commit to kellnr/kellnr that referenced this pull request Sep 1, 2026
Adds sending multiple aud in the token during oauth2 and kellnr right now need the
aud to only have the clientId in aud.

kellnr helm PR : kellnr/helm#93
@secana

secana commented Sep 1, 2026

Copy link
Copy Markdown
Member

Heads-up before you see the notifications: I am about to close and immediately reopen this PR. Nothing is wrong with it, and no action is needed from you.

The Lint and install failure here was chart version not ok. Needs a version bump!. That requirement was wrong on our side, not yours: requiring a bump per pull request would force a chart release for every merge. #94 turns the check off and makes chart-releaser skip a version that already has a release, so a change can merge and simply ship with the next bump.

Re-running the job did not pick that up. For a pull request from a fork the workflow checks out the merge of your branch into main, and a re-run reuses the merge commit computed when the event first fired, which predates #94. Closing and reopening forces a fresh one, so lint runs against the new config.

No rebase needed: the PR is conflict-free, the ruleset does not require the branch to be up to date, and this PR does not touch Chart.yaml, so main's current version and appVersion win on merge either way.

I will follow up with the actual review of the change itself.

@secana secana closed this Sep 1, 2026
@secana secana reopened this Sep 1, 2026
@secana
secana merged commit cbc6f58 into kellnr:main Sep 1, 2026
1 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants