self-development: widen cross-spawner dedup and reduce focus area overlap#556
Merged
self-development: widen cross-spawner dedup and reduce focus area overlap#556
Conversation
gjkim42
approved these changes
Mar 5, 2026
There was a problem hiding this comment.
4 issues found across 3 files
Prompt for AI agents (unresolved issues)
Check if these issues are valid — if so, understand the root cause of each and fix them. If appropriate, use sub-agents to investigate and fix each issue separately.
<file name="self-development/kelos-self-update.yaml">
<violation number="1" location="self-development/kelos-self-update.yaml:85">
P0: YAML indentation bug: this line is at 4-space indent, which exits the `promptTemplate: |` literal block scalar (whose key is also at 4 spaces). This will cause a YAML parse error at deploy time, as a sequence item (`-`) cannot appear directly inside the `taskTemplate` mapping. Indent to 6 spaces to keep this line inside the prompt template.</violation>
</file>
<file name="self-development/kelos-fake-user.yaml">
<violation number="1" location="self-development/kelos-fake-user.yaml:70">
P0: **YAML indentation bug**: This line has 4 spaces of indentation but should have 6 to remain inside the `promptTemplate: |` block scalar. As written, this line exits the block scalar and becomes an invalid YAML sequence item at the `taskTemplate` level, breaking the entire manifest with a parse error.</violation>
</file>
<file name="self-development/kelos-fake-strategist.yaml">
<violation number="1" location="self-development/kelos-fake-strategist.yaml:45">
P2: The README still lists "Workflow Improvements" as a focus area for kelos-fake-strategist (line 154 of `self-development/README.md`), but this PR removes that focus area. Update the README in the same PR to stay in sync.
(Based on your team's feedback about keeping documentation and config updated with changes.) [FEEDBACK_USED]</violation>
<violation number="2" location="self-development/kelos-fake-strategist.yaml:75">
P2: Indentation bug: this bullet has 4 spaces of indentation while all other Constraints bullets have 6 spaces. Since this is inside a `promptTemplate: |` literal block, the misaligned indentation is preserved verbatim in the prompt, making this bullet appear outside the Constraints list to the agent.</violation>
</file>
Reply with feedback, questions, or to request a fix. Tag @cubic-dev-ai to re-run a review.
gjkim42
requested changes
Mar 5, 2026
Collaborator
gjkim42
left a comment
There was a problem hiding this comment.
fix the PR based on review comments
/reset-worker
gjkim42
approved these changes
Mar 5, 2026
Collaborator
|
/squash-commits |
f68d813 to
b5a49b9
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind cleanup
What this PR does / why we need it:
The four cron-based issue-creating agents each check
gh issue list --label generated-by-kelos --limit 10before creating issues, but the repository has 30+ open generated-by-kelos issues. This means agents miss most existing issues during dedup checks, leading to thematic overlap and wasted runs.This PR makes three prompt-only changes to reduce duplicate issue creation:
--limit 10with--limit 50 --json number,titlein kelos-fake-strategist, kelos-fake-user, and kelos-self-update so agents see all open generated-by-kelos issues (compact JSON output keeps context usage low)Change 3 from the issue (add spawner name to issue titles) is deferred to #549 per triage recommendation.
Which issue(s) this PR is related to:
Fixes #553
Special notes for your reviewer:
These are prompt-only changes to self-development TaskSpawner YAML files. No code changes, no CRD changes, no API changes.
Does this PR introduce a user-facing change?
Summary by cubic
Reduces duplicate issue creation across cron agents by widening dedup checks and clarifying each agent’s scope. Fixes #553 by having agents review all open generated-by-kelos issues and avoid overlap.
gh issue list --label generated-by-kelos --state open --limit 50 --json number,titlein kelos-fake-strategist, kelos-fake-user, and kelos-self-update.Written for commit b5a49b9. Summary will update on new commits.