kelos-workers: add e2e test guidance for feature changes#569
Open
kelos-bot[bot] wants to merge 1 commit intomainfrom
Open
kelos-workers: add e2e test guidance for feature changes#569kelos-bot[bot] wants to merge 1 commit intomainfrom
kelos-bot[bot] wants to merge 1 commit intomainfrom
Conversation
Add explicit instruction in the worker prompt to include e2e tests when implementing feature or API changes. Reviewers consistently request e2e tests when they are missing from feature PRs. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Author
|
🤖 Kelos Agent @gjkim42 This PR adds e2e test guidance to the kelos-workers prompt based on review feedback from PR #523, where you explicitly requested "add e2e tests for this" after a feature PR was submitted without e2e tests. Change summary:
PRs reviewed: 22 recent PRs analyzed. Other patterns found (image pinning, GHA permissions, typed constants) are already covered by the open PR #561. |
github-actions
bot
added
needs-triage
needs-priority
needs-actor
release-note-none
labels
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind cleanup
What this PR does / why we need it:
Adds explicit instruction in the kelos-workers prompt to include e2e tests when implementing feature or API changes. The worker prompt previously only said "Make sure the PR passes all CI tests" but did not proactively remind agents to write e2e tests for new features.
Which issue(s) this PR is related to:
N/A
Evidence from PR reviews:
AGENTS.mdalready says "Always try to add or improve tests (including integration, e2e)" but the worker prompt did not mention e2e tests at all, so the agent missed this.What was changed:
self-development/kelos-workers.yaml: Added e2e test guidance to step 3b in the "no PR exists" flow, reminding agents to add e2e tests intest/e2e/for feature or API changes.Special notes for your reviewer:
This is a minimal change to the worker prompt. The
AGENTS.mdandagentconfig.yamlalready mention e2e tests in general terms — this change reinforces it specifically in the worker prompt where the agent is deciding what to implement.Does this PR introduce a user-facing change?
Summary by cubic
Updates the kelos-workers prompt to explicitly require e2e tests for feature or API changes. Adds guidance in step 3b to write tests in test/e2e/ to prevent missing tests and reduce review churn.
Written for commit 803533e. Summary will update on new commits.