Remove dedicated toggle thinking button - #97
Merged
Conversation
The block type filter dropdown already includes thinking as a filterable block type, making the standalone toggle button and its `t` keyboard shortcut redundant. Remove the button, shortcut, `toggleThinking()` method, `showThinking` getter, and associated tests. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
roborev: Combined Review (
|
The dedicated toggle thinking button and keyboard shortcut were removed in favor of the block type filter dropdown. Update the e2e test to open the filter dropdown and click the "Thinking blocks" item instead of pressing the removed "t" shortcut. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
roborev: Combined Review (
|
cursor Bot
pushed a commit
to diazMelgarejo/periscope
that referenced
this pull request
Jun 1, 2026
## Summary - Remove the standalone "Toggle thinking blocks" button from the session header toolbar - The block type filter dropdown already includes thinking as a filterable block type, making the dedicated button redundant - Remove the `t` keyboard shortcut, `toggleThinking()` method, `showThinking` getter, and associated tests ## Test plan - [ ] Verify thinking blocks can still be toggled via the block filter dropdown - [ ] Verify the `t` key no longer has any effect - [ ] All 574 frontend tests pass 🤖 Generated with [Claude Code](https://claude.com/claude-code) --------- Co-authored-by: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
tkeyboard shortcut,toggleThinking()method,showThinkinggetter, and associated testsTest plan
tkey no longer has any effect🤖 Generated with Claude Code