fix(beeper): report durable over-cap media skips - #648
Merged
wesm merged 1 commit intoAug 20, 2026
Conversation
roborev: Combined Review (
|
This was referenced Aug 22, 2026
Closed
wesm
pushed a commit
to salmonumbrella/msgvault
that referenced
this pull request
Sep 4, 2026
Beeper, Slack, Discord, and Teams now skip attachment downloads from conversations with more than 20 participants unless the operator sets media_max_participants. This keeps high-volume group rooms from consuming the archive's media budget while direct chats and small groups keep their media. An explicit media_max_participants = 0 still disables the cap. Skipped occurrences keep the participant_threshold marker, so backfill retries them only after the cap changes. This squashed change also includes: - feat(media): raise the chat media size default to 250 MiB The higher Beeper, Slack, and Teams size limit keeps long voice notes, screen recordings, and phone video from direct chats. Discord keeps its 50 MiB default, and an explicit max_media_mb remains unchanged. Refs kenn-io#634 kenn-io#620 kenn-io#632 kenn-io#648 Generated with Codex Co-authored-by: Claude Fable 5.1 <noreply@anthropic.com> Co-authored-by: Codex <noreply@openai.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
at leastqualifier when the total is only a lower bound.Why
An over-cap attachment currently looks like generic pending work and can be revisited indefinitely even though the same configured cap will reject it again. Operators cannot tell how much media was deliberately excluded, and repeated backfills can spend the same network work without changing the archive. This makes the terminal policy outcome visible and ties retries to an actual cap change.
Usage
No usage change.
Builds on #620. Refs #632.