Add Tech section to README + support static storybook #161
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
liorheber
reviewed
Feb 11, 2021
| **Installation using Yarn:** | ||
|
|
||
| ``` | ||
| yarn add @kenshooui/react-tree |
Contributor
There was a problem hiding this comment.
lets ensure the readme files contain a link to the demo page.
liorheber
reviewed
Feb 11, 2021
| all_branches: true | ||
| all_branches: true | ||
| - provider: pages | ||
| local-dir: "./storybook-static" |
Contributor
There was a problem hiding this comment.
Are you sure storybook is generated in the root folder and not in the doc folder? I'm not sure.
Contributor
Author
There was a problem hiding this comment.
I'm not really sure what "./storybook-static" means..I didn't find storybook-static in react-multi-select
In react tree the storybook is created inside doc folder, how can we know where is the storybook generated?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📦 Published PR as canary version:
Canary Versions✨ Test out this PR locally via:
npm install @kenshooui/react-tree@0.0.25-canary.161.454.0 npm install @kenshooui/material-tree@0.0.8-canary.161.454.0 # or yarn add @kenshooui/react-tree@0.0.25-canary.161.454.0 yarn add @kenshooui/material-tree@0.0.8-canary.161.454.0