Skip to content

Add Tech section to README + support static storybook #161

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
liorheber merged 2 commits into from
Feb 23, 2021
Merged

Add Tech section to README + support static storybook #161

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
27f7783
Add Tech section to README + support static storybook
liatgo Feb 11, 2021
27fe38b
build storybook
liatgo Feb 15, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 9 additions & 1 deletion .travis.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,6 +28,7 @@ script:

after_success:
- ./cc-test-reporter after-build --exit-code $TRAVIS_TEST_RESULT
- yarn build-storybook

before_deploy:
- if [ "$BRANCH" == "master" ]; then
Expand All @@ -40,4 +41,11 @@ deploy:
script: if [ "$GH_TOKEN" != "false" ]; then npx auto shipit; fi;
skip-cleanup: true
on:
all_branches: true
all_branches: true
- provider: pages
local-dir: "./storybook-static"
Copy link
Contributor

@liorheber liorheber Feb 11, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are you sure storybook is generated in the root folder and not in the doc folder? I'm not sure.

Copy link
Contributor Author

@liatgo liatgo Feb 11, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not really sure what "./storybook-static" means..I didn't find storybook-static in react-multi-select
In react tree the storybook is created inside doc folder, how can we know where is the storybook generated?

skip-cleanup: true
github-token: $GH_TOKEN
keep-history: true
on:
branch: master
5 changes: 5 additions & 0 deletions packages/core/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,11 @@ Examples can be found - [here](https://github.com/kenshoo/react-tree/blob/master
yarn add @kenshooui/react-tree
Copy link
Contributor

@liorheber liorheber Feb 11, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lets ensure the readme files contain a link to the demo page.

```

### Technologies

* React 16
* @emotion/core

### How to use
<!-- example -->

Expand Down
6 changes: 6 additions & 0 deletions packages/material_tree/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,6 +30,12 @@ Examples can be found - [here](https://github.com/kenshoo/react-tree/blob/master
yarn add @material-ui/core @material-ui/icons
```

### Technologies

* React 16
* @material-ui/core
* @material-ui/icons

### How to use
<!-- example -->

Expand Down