Fix security issues: remove eval(), use secrets for crypto, pin CI actions#2739
Merged
Fix security issues: remove eval(), use secrets for crypto, pin CI actions#2739
Conversation
…tions - Remove eval() in kth_to_last_eval, replace with safe iterative loop (#2728) - Replace random module with secrets in rsa.py, diffie_hellman_key_exchange.py, rabin_miller.py for cryptographically secure RNG (#2729) - Replace unbounded _modinv while-loop with extended Euclidean algorithm that raises ValueError on non-coprime inputs (#2730) - Pin all GitHub Actions in publish.yml to commit SHAs (#2731) - Fix float division num /= 2 → num //= 2 in rabin_miller.py and correct _pow2_factor return type annotation (#2733) Closes #2728, closes #2729, closes #2730, closes #2731, closes #2733 Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
- Make _extended_gcd iterative to prevent RecursionError on large keys - Fix pypa/gh-action-pypi-publish SHA to correct commit hash Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
eval()inkth_to_last_eval, replace with safe iterative loop (Security: Remove eval() usage in linked_list/kth_to_last.py #2728)randommodule withsecretsinrsa.py,diffie_hellman_key_exchange.py,rabin_miller.py(Security: Crypto functions use random instead of secrets (RSA, DH, Rabin-Miller) #2729)_modinvwhile-loop with extended Euclidean algorithm (Bug: _modinv in rsa.py has unbounded while loop — infinite loop on invalid input #2730)publish.ymlto commit SHAs (Security: Pin GitHub Action SHAs in publish workflow #2731)num /= 2→num //= 2inrabin_miller.py(Bug: Float division in rabin_miller.py corrupts primality test #2733)Test plan
python -m pytest tests/test_math.py tests/test_linked_list.py -x -q— 62 tests passeval()remaining in codebaseimport randomin crypto modulesCloses #2728, #2729, #2730, #2731, #2733
🤖 Generated with Claude Code