Fixed non-square album art pushing adjacent albums out of alignment - #136
Closed
Emberr wants to merge 1 commit into
Closed
Fixed non-square album art pushing adjacent albums out of alignment#136Emberr wants to merge 1 commit into
Emberr wants to merge 1 commit into
Conversation
…n the Album view. Addressing issue kepelet#108.
Member
|
nice, thanks! is that work with the default (album with no cover) and fallback (failed to load album cover) too? |
Author
|
Yes, it does work with them. See below. |
Member
|
great! what devices you use on simulator? i want to fix that overlapped floating player |
Author
|
I am using the 17 Pro Max on the simulator. |
Member
|
closing this as all commits have been cherrypicked to release/2.4 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixed an issue noted in #108 that affected non-standard album covers to push adjacent albums out of alignment.
Cassette and other album art is now scaled to fill a square.
Before:
After: