Skip to content

feat: grant aepfli approver status for lifecycle-toolkit#272

Merged
thisthat merged 1 commit into
keptn:mainfrom
aepfli:member/239-grant-aepfli-approver-status-for-lifecycle-toolkit
Apr 12, 2023
Merged

feat: grant aepfli approver status for lifecycle-toolkit#272
thisthat merged 1 commit into
keptn:mainfrom
aepfli:member/239-grant-aepfli-approver-status-for-lifecycle-toolkit

Conversation

@aepfli
Copy link
Copy Markdown
Member

@aepfli aepfli commented Apr 5, 2023

As @aepfli is heavily involved in the documentation and linter setup, it would be good to see the appprovals of this member as a real and valuable approval. Currently, as the member is not part this approval does not count for the number of needed approvals.

closes: #239

@mowies mowies changed the title feat: grant aepfli approver status for lifecycle-toolkit #239 feat: grant aepfli approver status for lifecycle-toolkit Apr 6, 2023
As @aepfli is heavily involved in the documentation and linter
setup, it would be good to see the appprovals of this member as
a real and valuable approval. Currently, as the member is not part
this approval does not count for the number of needed approvals.

closes:  keptn#239

Signed-off-by: Simon Schrottner <simon.schrottner@dynatrace.com>
@aepfli aepfli force-pushed the member/239-grant-aepfli-approver-status-for-lifecycle-toolkit branch from 049ad2e to db1c1a6 Compare April 6, 2023 08:08
@aepfli aepfli marked this pull request as ready for review April 6, 2023 08:09
@aepfli aepfli requested review from a team as code owners April 6, 2023 08:09
Copy link
Copy Markdown
Member

@thisthat thisthat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your valuable support on the documentation website @aepfli
Well deserved 👍

I will merge this PR in 48h to allow everyone to comment

@thisthat thisthat merged commit 85b0a55 into keptn:main Apr 12, 2023
@mowies mowies deleted the member/239-grant-aepfli-approver-status-for-lifecycle-toolkit branch April 17, 2023 05:39
aepfli added a commit to aepfli/aepfli.github.io that referenced this pull request Apr 30, 2026
Break out flagd ecosystem (flagd, flagd-evaluator, flagd-testbed) under
OpenFeature, promote Keptn to its own section noting approver status
(keptn/community#272), add OpenTelemetry Demo (#2114), add JoustMania as
the demo platform behind the KubeCon EU 2026 talk, and mention the
cucumber-rs contribution. Update .spelling for new proper nouns.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

REQUEST: Membership approver for aepfli for KLT

3 participants