-
Notifications
You must be signed in to change notification settings - Fork 9
Move scaling guide to Introduction as "Scale" #442
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
5985624
Move scaling guide to introduction/scale with redirect
AnnaXWang 1495420
Apply suggestion from @AnnaXWang
AnnaXWang 26a6bad
Retrigger Mintlify preview build
AnnaXWang 24b241c
Add trailing newline to style.css
AnnaXWang 5160e71
address comment
AnnaXWang 9aaace0
fix grammar
AnnaXWang ff99594
Address comments
AnnaXWang File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -247,4 +247,4 @@ html.dark .callout[class*="yellow"] svg { | |
|
|
||
| .dark .card:hover { | ||
| border-color: rgb(223 223 223) !important; | ||
| } | ||
| } | ||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Scale page uses CDP examples
Medium Severity
This PR moves the scaling guide to
introduction/scaleand lists it under Overview with Create, Control, and Observe, but the architecture accordions still drive browsers only viachromium.connectOverCDP. For intro/overview pages, docs should treat the Playwright Execution API as the default Playwright pattern, likeintroduction/createandintroduction/control.Triggered by learned rule: Promote Playwright Execution API over direct CDP connections in examples
Reviewed by Cursor Bugbot for commit 1495420. Configure here.