chore: test reliability and speed skill - #133
Merged
Merged
Conversation
sjmiller609
marked this pull request as ready for review
March 8, 2026 17:45
There was a problem hiding this comment.
Automated risk assessment (based on code diff evidence only): Medium-High risk.
Why this is not low-risk:
lib/network/allocate.gochanges shared allocation behavior by introducing self-heal retry/polling logic in default network retrieval (CreateAllocationandRecreateAllocationpaths).lib/ingress/binaries_linux.gochanges concurrent binary extraction semantics (cross-process file lock + atomic write/rename path).- New instruction files under
skills/test-agent/agents/test-agent/PROMPT.mdmaterially change prompt behavior for an automation agent.
Decision:
- Code review required.
- No self-approval for Medium-High risk.
- Reviewer assignment not changed because 2 reviewers are already assigned (
rgarcia,hiroTamada) and max is 2.
Additional checks:
- No existing approvals were present, so no approval dismissal action was needed.
- No
CODEOWNERSfile was found in-repo, so codeowners-specific blocking could not be inferred from repository files.
sjmiller609
enabled auto-merge (squash)
March 8, 2026 18:19
hiroTamada
approved these changes
Mar 9, 2026
hiroTamada
left a comment
Contributor
There was a problem hiding this comment.
looks good -- solid flake fixes and test speed improvements. left one minor suggestion on the skill docs.
| description: Improve repository test quality by eliminating flakes first, then reducing slow-test redundancy, and finally optimizing longest tests while preserving coverage. Use when asked to repeatedly run CI-equivalent no-cache test cycles, diagnose flaky tests, and document findings in this skill's notes. | ||
| --- | ||
|
|
||
| Follow the workflow and constraints documented in [agents/test-agent/PROMPT.md](agents/test-agent/PROMPT.md). Do not modify this file. |
Contributor
There was a problem hiding this comment.
consider adding a getting-started section covering environment setup (e.g. required OS, root access, firecracker/qemu binaries, bridge networking prereqs) and how to generate any tokens or credentials needed to run the test suite. right now someone picking up this skill for the first time would need to reverse-engineer the setup from the test code and CI config.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


Note
Medium Risk
Touches runtime paths for ingress binary extraction and default-network discovery, so any bugs could affect multi-process startups or instance networking on Linux. Changes are bounded (file-lock + atomic rename; short self-heal polling) and mainly aimed at reducing CI flakiness.
Overview
Improves Linux integration test reliability by hardening embedded Caddy extraction:
ExtractCaddyBinarynow uses a per-binaryFlockand temp-file + atomic rename writes (including the.sha256) to avoid concurrentETXTBUSY/partial-write races.Makes default-network allocation more robust under concurrent tests by adding
getDefaultNetworkWithSelfHeal, which re-runs initialization and briefly polls for bridge readiness before failing.Reduces test flakiness/latency by removing an external S3 curl dependency in
TestFirecrackerNetworkLifecycle(replaced with a local probe server), trimming redundant reachability assertions in running-fork tests, and lowering guest execWaitForAgenttimeout inexecInInstanceto speed up polling-based assertions.Adds a new
skills/test-agentskill with prompt and investigation notes documenting the flake root causes and validation runs.Written by Cursor Bugbot for commit c94b92d. This will update automatically on new commits. Configure here.