Use 4973 as the default Hypeman port - #347
Conversation
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes using high effort and found 1 potential issue.
Autofix Details
Bugbot Autofix prepared a fix for the issue found in the latest run.
- ✅ Fixed: Installer port skews before release
- Updated install.sh to fall back to a commented
# port:value when no activeport:key exists, keeping CLI base_url aligned with the installed release config default.
- Updated install.sh to fall back to a commented
Or push these changes by commenting:
@cursor push 03593d9495
Preview (03593d9495)
diff --git a/scripts/install.sh b/scripts/install.sh
--- a/scripts/install.sh
+++ b/scripts/install.sh
@@ -768,6 +768,10 @@
CLI_PORT="4973"
if [ -f "$CONFIG_FILE" ]; then
PARSED_PORT=$(grep -E '^[[:space:]]*port[[:space:]]*:' "$CONFIG_FILE" 2>/dev/null | head -1 | sed 's/^[[:space:]]*port[[:space:]]*:[[:space:]]*//' | tr -d "\"'" | sed 's/[[:space:]]*$//' || true)
+ # Linux templates keep port commented out; use it as a fallback to avoid release skew.
+ if [ -z "$PARSED_PORT" ]; then
+ PARSED_PORT=$(grep -E '^[[:space:]]*#[[:space:]]*port[[:space:]]*:' "$CONFIG_FILE" 2>/dev/null | head -1 | sed 's/^[[:space:]]*#[[:space:]]*port[[:space:]]*:[[:space:]]*//' | tr -d "\"'" | sed 's/[[:space:]]*$//' || true)
+ fi
if [ -n "$PARSED_PORT" ]; then
CLI_PORT="$PARSED_PORT"
fiYou can send follow-ups to the cloud agent here.
|
Fixed the installer port skew in 325d7de: CLI config generation now reads the commented default port from release config files when no active port override exists. |
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes using high effort and found 1 potential issue.
Bugbot Autofix prepared a fix for the issue found in the latest run.
- ✅ Fixed: Commented port treated as live
- Removed the fallback that parsed commented
# port:lines so CLIbase_urlnow only uses an activeportsetting or defaults to4973.
- Removed the fallback that parsed commented
Or push these changes by commenting:
@cursor push ad35491fce
Preview (ad35491fce)
diff --git a/scripts/install.sh b/scripts/install.sh
--- a/scripts/install.sh
+++ b/scripts/install.sh
@@ -768,9 +768,6 @@
CLI_PORT="4973"
if [ -f "$CONFIG_FILE" ]; then
PARSED_PORT=$(grep -E '^[[:space:]]*port[[:space:]]*:' "$CONFIG_FILE" 2>/dev/null | head -1 | sed 's/^[[:space:]]*port[[:space:]]*:[[:space:]]*//' | tr -d "\"'" | sed 's/[[:space:]]*$//' || true)
- if [ -z "$PARSED_PORT" ]; then
- PARSED_PORT=$(grep -E '^[[:space:]]*#[[:space:]]*port[[:space:]]*:' "$CONFIG_FILE" 2>/dev/null | head -1 | sed 's/^[[:space:]]*#[[:space:]]*port[[:space:]]*:[[:space:]]*//' | tr -d "\"'" | sed 's/[[:space:]]*$//' || true)
- fi
if [ -n "$PARSED_PORT" ]; then
CLI_PORT="$PARSED_PORT"
fiYou can send follow-ups to the cloud agent here.
Reviewed by Cursor Bugbot for commit 325d7de. Configure here.
|
Addressed the follow-up in c390629 without treating an existing commented setting as active: the installer derives the fallback from the selected release’s staged config template, then applies only an active override from the installed config. |


Summary
Tests
GOCACHE=/tmp/hypeman-go-cache GOPATH=/tmp/hypeman-gopath go test ./cmd/api/config ./deploy/aws/cloudformationbash -n scripts/install.sh scripts/e2e-install-test.shgo test ./cmd/api/apirequires embedded runtime binaries that are not present in the checkout; the repository CI runs the complete test jobs with release assets prepared.Note
Medium Risk
Default port and registry URL changes affect fresh installs, CLI config, and VM/build registry reachability; existing deployments with explicit config are unaffected, but anyone relying on implicit 8080 must update clients or firewall rules.
Overview
The default Hypeman API and built-in registry port moves from 8080 to 4973 across server config (
defaultConfig, build manager, ingress/registry wiring), env and YAML examples, docs, OpenAPI (0.3.0, server URL), Stainless, and e2e/install scripts.The install script now defaults CLI
base_urlto 4973 and reads the port from the bundled example config (including commented# port:lines) before the live server config. A unit test locks in the new default port and registry URL.AWS CloudFormation quickstart is unchanged and still defaults API port 8080.
Reviewed by Cursor Bugbot for commit c390629. Bugbot is set up for automated code reviews on this repo. Configure here.