Prefer KERNEL_INSTANCE_JWT in browser images#226
Merged
Conversation
Normalize the generic instance JWT env var into Envoy bootstrap rendering and the kernel-images API process while keeping XDS_JWT as a compatibility fallback during the migration.
|
Firetiger deploy monitoring skipped This PR didn't match the auto-monitor filter configured on your GitHub connection:
Reason: PR modifies Envoy bootstrap configuration and environment variables, not kernel API endpoints or Temporal workflows. To monitor this PR anyway, reply with |
Make KERNEL_INSTANCE_JWT the only token contract in the public browser image runtime now that the control-plane release will land first.
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
Bugbot Autofix is ON. A cloud agent has been kicked off to fix the reported issue. You can view the agent here.
Reviewed by Cursor Bugbot for commit 3d1737c. Configure here.
sjmiller609
approved these changes
Apr 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Summary
KERNEL_INSTANCE_JWTas the only token contractXDS_JWTreferences from the public image repoTest plan
bash -n shared/envoy/init-envoy.shNote
Medium Risk
Changes the JWT env var contract used to authenticate Envoy xDS requests; deployments still providing
XDS_JWTwill fail Envoy init until updated. Scope is limited to bootstrap templating and startup checks, with no behavioral changes beyond token source.Overview
Switches Envoy xDS authentication in the browser image runtime from
XDS_JWTtoKERNEL_INSTANCE_JWT.Updates
shared/envoy/bootstrap.yamlto sendauthorization: Bearer {KERNEL_INSTANCE_JWT}, and adjustsshared/envoy/init-envoy.shto require this env var, map it through a singleINSTANCE_JWT, and render the template using the new placeholder (including updated logging).Reviewed by Cursor Bugbot for commit 2f18d3e. Bugbot is set up for automated code reviews on this repo. Configure here.