Skip to content

Prefer KERNEL_INSTANCE_JWT in browser images #226

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rgarcia merged 3 commits into from
Apr 23, 2026
Merged

Prefer KERNEL_INSTANCE_JWT in browser images #226

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
0ade5f3
Prefer KERNEL_INSTANCE_JWT in browser images.
rgarcia Apr 23, 2026
3d1737c
Remove XDS_JWT references from browser images.
rgarcia Apr 23, 2026
2f18d3e
Merge branch 'main' into rgarcia/phase1-instance-jwt
rgarcia Apr 23, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions shared/envoy/bootstrap.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
# Envoy bootstrap configuration for xDS-managed proxy
# This config connects to a control plane for dynamic configuration management
# Requires: INST_NAME, METRO_NAME, XDS_SERVER, XDS_JWT environment variables
# Requires: INST_NAME, METRO_NAME, XDS_SERVER, and KERNEL_INSTANCE_JWT
# environment variables

# Node identity sent to xDS server for configuration targeting, authenticated by JWT
node:
Expand All @@ -21,7 +22,7 @@ dynamic_resources:
# Send JWT authentication for all xDS requests
initial_metadata:
- key: "authorization"
value: "Bearer {XDS_JWT}"
value: "Bearer {KERNEL_INSTANCE_JWT}"

# Listener Discovery Service and Cluster Discovery Service use ADS
lds_config:
Expand Down
12 changes: 8 additions & 4 deletions shared/envoy/init-envoy.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,8 +2,12 @@

set -o pipefail -o errexit -o nounset

# The browser instance JWT is the sole token contract for xDS and host-local
# services in the image runtime.
INSTANCE_JWT="${KERNEL_INSTANCE_JWT:-}"
Comment thread
rgarcia marked this conversation as resolved.

# Check for required environment variables, to see if envoy is enabled
if [[ -z "${INST_NAME:-}" || -z "${METRO_NAME:-}" || -z "${XDS_SERVER:-}" || -z "${XDS_JWT:-}" ]]; then
if [[ -z "${INST_NAME:-}" || -z "${METRO_NAME:-}" || -z "${XDS_SERVER:-}" || -z "${INSTANCE_JWT:-}" ]]; then
echo "[envoy-init] Required environment variables not set. Skipping Envoy initialization."
exit 0
fi
Expand Down Expand Up @@ -55,15 +59,15 @@ else
fi

# Render template with provided environment variables
echo "[envoy-init] Rendering template with INST_NAME=${INST_NAME}, METRO_NAME=${METRO_NAME}, XDS_SERVER=${XDS_SERVER}, XDS_JWT=***"
echo "[envoy-init] Rendering template with INST_NAME=${INST_NAME}, METRO_NAME=${METRO_NAME}, XDS_SERVER=${XDS_SERVER}, KERNEL_INSTANCE_JWT=***"
inst_esc=$(printf '%s' "$INST_NAME" | sed -e 's/[\/&]/\\&/g')
metro_esc=$(printf '%s' "$METRO_NAME" | sed -e 's/[\/&]/\\&/g')
xds_esc=$(printf '%s' "$XDS_SERVER" | sed -e 's/[\/&]/\\&/g')
jwt_esc=$(printf '%s' "$XDS_JWT" | sed -e 's/[\/&]/\\&/g')
jwt_esc=$(printf '%s' "$INSTANCE_JWT" | sed -e 's/[\/&]/\\&/g')
sed -e "s|{INST_NAME}|$inst_esc|g" \
-e "s|{METRO_NAME}|$metro_esc|g" \
-e "s|{XDS_SERVER}|$xds_esc|g" \
-e "s|{XDS_JWT}|$jwt_esc|g" \
-e "s|{KERNEL_INSTANCE_JWT}|$jwt_esc|g" \
/etc/envoy/templates/bootstrap.yaml > /etc/envoy/bootstrap.yaml

echo "[envoy-init] Starting Envoy via supervisord"
Expand Down
Loading