ci(publish-mcp): simplify login command usage#48
Merged
masnwilliams merged 2 commits intomainfrom Sep 10, 2025
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
![mesa-dot-dev[bot]](https://avatars.githubusercontent.com/in/1050077?s=60&v=4){kind=small}
There was a problem hiding this comment.
Performed full review of 2823daa...984bd51
Tip
⚡ Quick Actions
This review was generated by Mesa.
Actions:
Slash Commands:
/review- Request a full code review/review latest- Review only changes since the last review/describe- Generate PR description. This will update the PR body or issue comment depending on your configuration/help- Get help with Mesa commands and configuration options
1 files reviewed | 1 comments | Review on Mesa | Edit Reviewer Settings
| run: | | ||
| echo "${{ secrets.MCP_PRIVATE_KEY }}" > key.pem | ||
| ./mcp-publisher login dns --domain onkernel.com --private-key-file key.pem | ||
| ./mcp-publisher login dns -domain onkernel.com -private-key "${{ secrets.MCP_PRIVATE_KEY }}" |
There was a problem hiding this comment.
Security concern: Passing the private key directly as a command line argument may expose it in process lists, shell history, and monitoring tools. Consider using environment variables or stdin piping instead: echo "${{ secrets.MCP_PRIVATE_KEY }}" | ./mcp-publisher login dns -domain onkernel.com --private-key-stdin (if supported) or setting MCP_PRIVATE_KEY as an environment variable.
Agent: 🤖 General
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TL;DR
Simplifies the login command in the
publish-mcpCI workflow by passing the private key directly as an argument.Why we made these changes
The previous method of writing the private key to a temporary file was unnecessarily complex. This change makes the workflow cleaner, more direct, and easier to understand.
What changed?
.github/workflows/publish-mcp.yml: Updated theLogin to MCP Registrystep to pass theMCP_PRIVATE_KEYsecret directly to themcp-publisher logincommand, removing the need for an intermediate file.Description generated by Mesa. Update settings