Skip to content

ci(publish-mcp): simplify login command usage #48

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
masnwilliams merged 2 commits into from
Sep 10, 2025
+1 −2
Merged

ci(publish-mcp): simplify login command usage #48

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8c2aa5d
ci(publish-mcp): simplify login command usage
masnwilliams Sep 10, 2025
984bd51
Merge branch 'main' into mason/ga-release
masnwilliams Sep 10, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions .github/workflows/publish-mcp.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,8 +38,7 @@ jobs:

- name: Login to MCP Registry
run: |
echo "${{ secrets.MCP_PRIVATE_KEY }}" > key.pem
./mcp-publisher login dns --domain onkernel.com --private-key-file key.pem
./mcp-publisher login dns -domain onkernel.com -private-key "${{ secrets.MCP_PRIVATE_KEY }}"
Copy link
Copy Markdown

@mesa-dot-dev mesa-dot-dev Bot Sep 10, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Medium Security

Security concern: Passing the private key directly as a command line argument may expose it in process lists, shell history, and monitoring tools. Consider using environment variables or stdin piping instead: echo "${{ secrets.MCP_PRIVATE_KEY }}" | ./mcp-publisher login dns -domain onkernel.com --private-key-stdin (if supported) or setting MCP_PRIVATE_KEY as an environment variable.
Agent: 🤖 General


- name: Publish to MCP Registry
run: ./mcp-publisher publish