Fix: avoid backend exit#1327
Merged
Merged
Conversation
giubrocchi
approved these changes
Jul 7, 2025
gabrielBatistella
approved these changes
Jul 7, 2025
MarceloRobert
force-pushed
the
fix/avoid-backend-exit
branch
from
8113366 to
adcd19d
Compare
giubrocchi
reviewed
Jul 7, 2025
Comment on lines
+442
to
+444
| for option in options: | ||
| match option: | ||
| case "ignore_default_recipients": |
Contributor
There was a problem hiding this comment.
Can we simplify this to:
Suggested change
| for option in options: | |
| match option: | |
| case "ignore_default_recipients": | |
| if "ignore_default_recipients" in options: |
MarceloRobert
force-pushed
the
fix/avoid-backend-exit
branch
from
adcd19d to
2f7b2a6
Compare
A lower complexity is needed so that the linter doesn't complain with future functionalities
The kcidb_execute_query allows for a sys.exit since it was only used in a command context. Since it is now used in the full backend context, it should be avoided in order to allow for an error 500 instead of exiting the backend Closes #1328
MarceloRobert
force-pushed
the
fix/avoid-backend-exit
branch
from
2f7b2a6 to
a40a5e5
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The kcidb_execute_query allows for a sys.exit since it was only used in a command context. Since it is now used in the full backend context, it should be avoided in order to allow for an error 500 instead of exiting the backend
Changes
kcidb_execute_querywith the usual cursor and dictfetchallHow to test
Closes #1328