Skip to content

fix: Fix Hardware Details Link#1827

Merged
gustavobtflores merged 1 commit intokernelci:mainfrom
profusion:fix/logview-breadcrumb-hardware-links
Mar 27, 2026
Merged

fix: Fix Hardware Details Link#1827
gustavobtflores merged 1 commit intokernelci:mainfrom
profusion:fix/logview-breadcrumb-hardware-links

Conversation

@alanpeixinho
Copy link
Copy Markdown
Contributor

Description

Uses the from property, instead of directly capturing the hardwareId from url.
This way, any page that uses a proper id and indicates that we are coming from a hardware page is going to be interpreted as a hardwareId.

How to test

  1. Open the hardware listing page
  2. Click on a hardware to go to Hardware Details page
  3. Go to TestDetails or BuildDetails tab
  4. On the configs table access the BuildDetails/TestDetails page through the information icon (i).
  5. Click on the View Log Excerpt.
  6. Click on View full log for link.
  7. The second breadcrumb should show (and link to) HardwareDetails page, and not TreeDetails page.

Closes #1823 hardwareDetails -> boots tab -> testDetails/bootDetails -> log viewer

@alanpeixinho alanpeixinho marked this pull request as ready for review March 26, 2026 17:02
@gustavobtflores gustavobtflores added the Frontend Most or all of the changes for this issue will be in the frontend code. label Mar 26, 2026
 * Using the from property to indicate if the param id is hardwareId.

 Closes kernelci#1823
@alanpeixinho alanpeixinho force-pushed the fix/logview-breadcrumb-hardware-links branch from 53269d6 to 259dde4 Compare March 26, 2026 20:33
Copy link
Copy Markdown
Collaborator

@MarceloRobert MarceloRobert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One route is still incorrect:

hardwareListing -> hardwareDetails -> build/testDetails -> view full logs -> build/testDetails -> hardware Details. The text of the last link is correct but it redirects to /hardware/<tree_commit_hash>

@alanpeixinho
Copy link
Copy Markdown
Contributor Author

I believe this issue lies on the buildDetails.
Many such small cases might happen in unusual navigation.
Should we create a new issue to redesign the breadcrumbs?

@MarceloRobert
Copy link
Copy Markdown
Collaborator

I believe this issue lies on the buildDetails.

What I pointed out happens on both buildDetails and testDetails, I believe the problem is when getting out of the log viewer page

Copy link
Copy Markdown
Collaborator

@MarceloRobert MarceloRobert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The main problem was fixed, what I pointed out could be considered "a very specific case", so sure let's open an issue for improving the breadcrumb system and we can merge this small fix

@gustavobtflores gustavobtflores added this pull request to the merge queue Mar 27, 2026
Merged via the queue into kernelci:main with commit eb8033e Mar 27, 2026
7 checks passed
@MarceloRobert MarceloRobert added the bug Something isn't working label Mar 30, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working Frontend Most or all of the changes for this issue will be in the frontend code.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Fix breadcrumb links on logviewer

3 participants