fix: Fix Hardware Details Link#1827
Conversation
* Using the from property to indicate if the param id is hardwareId. Closes kernelci#1823
53269d6 to
259dde4
Compare
MarceloRobert
left a comment
There was a problem hiding this comment.
One route is still incorrect:
hardwareListing -> hardwareDetails -> build/testDetails -> view full logs -> build/testDetails -> hardware Details. The text of the last link is correct but it redirects to /hardware/<tree_commit_hash>
|
I believe this issue lies on the buildDetails. |
What I pointed out happens on both buildDetails and testDetails, I believe the problem is when getting out of the log viewer page |
MarceloRobert
left a comment
There was a problem hiding this comment.
The main problem was fixed, what I pointed out could be considered "a very specific case", so sure let's open an issue for improving the breadcrumb system and we can merge this small fix
Description
Uses the
fromproperty, instead of directly capturing the hardwareId from url.This way, any page that uses a proper
idand indicates that we are coming from a hardware page is going to be interpreted as a hardwareId.How to test
View Log Excerpt.View full log forlink.Closes #1823 hardwareDetails -> boots tab -> testDetails/bootDetails -> log viewer