dashboard: make the dashboard API URL configurable#286
Merged
Conversation
The dashboard API URL was hard-coded to the production dashboard, preventing queries against staging or internal KernelCI instances. Replace the DASHBOARD_API and DASHBOARD_URL constants with accessors backed by a module-level setting. The URL can now be set with a dashboard_api key in kci-dev.toml, either in an instance section or at the top level of the file, and library users can pass dashboard_api to KernelCIClient. The production dashboard remains the default when nothing is configured. Closes kernelci#237 Signed-off-by: Ben Copeland <ben.copeland@linaro.org>
Member
|
Thanks for this. was long time in my mind to add more flexible settings |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The dashboard API URL was hard-coded to the production dashboard, preventing queries against staging or internal KernelCI instances.
Replace the DASHBOARD_API and DASHBOARD_URL constants with accessors backed by a module-level setting. The URL can now be set with a dashboard_api key in kci-dev.toml, either in an instance section or at the top level of the file, and library users can pass dashboard_api to KernelCIClient. The production dashboard remains the default when nothing is configured.
Closes #237