Fix build emails blaiming wrong compiler by mattface · Pull Request #129 · kernelci/kernelci-backend

mattface · 2019-04-26T10:19:08Z

Remove the compiler string per arch and instead report an environment
for each build result.

mattface · 2019-04-29T16:48:49Z

Well, good news and bad news.

Build Failure Detected:

arm64:
    allmodconfig: (clang-8) FAIL

Warnings Detected:

arm64:

    defconfig: 42 warnings
    defconfig: 42 warnings
    defconfig: 42 warnings
    defconfig: 42 warnings
    defconfig: 42 warnings
    defconfig: 42 warnings
    defconfig: 42 warnings
    defconfig: 42 warnings
    defconfig: 42 warnings

So the correct build environment is shown for failures, however the warnings output seems to be garbage. I also spotted a debug log line in the commit, so don't merge this yet and I'll work on it.

nickdesaulniers · 2019-04-30T20:20:11Z

There's a current bug in Clang that is generating these 42 false positive warnings. My goal is to fix that in clang-9, but it's lower priority than some of the other bugs currently.

gctucker · 2019-05-01T11:57:53Z

Also:

$ pep8 app
app/utils/report/build.py:68:80: E501 line too long (95 > 79 characters)
app/utils/report/build.py:341:80: E501 line too long (97 > 79 characters)
app/utils/report/build.py:419:80: E501 line too long (80 > 79 characters)
app/utils/report/build.py:423:80: E501 line too long (81 > 79 characters)
app/utils/report/build.py:429:80: E501 line too long (81 > 79 characters)

gctucker · 2019-05-03T12:08:57Z

There was a problem with the modified build.jpl and new kci_build commands where errors and warnings were not published correctly in the backend. This has now been fixed, and here's today's build report showing the warnings and an expected build error:

kernelci/staging.kernelci.org build: 11 builds: 1 failed, 10 passed, 90 warnings (v5.1-rc7-132-g5a5a1390a19b)

Full Build Summary: https://staging.kernelci.org/build/kernelci/branch/staging.kernelci.org/kernel/v5.1-rc7-132-g5a5a1390a19b/

Tree: kernelci
Branch: staging.kernelci.org
Git Describe: v5.1-rc7-132-g5a5a1390a19b
Git Commit: 5a5a1390a19b943286aec284c5d66f50cbf7367f
Git URL: https://github.com/kernelci/linux.git
Built: 6 unique architectures

Build Failure Detected:

arm:
    multi_v7_defconfig: (clang-8) FAIL

Warnings Detected:

arc:
    nsim_hs_defconfig (gcc-8): 2 warnings

arm64:
    defconfig (gcc-8): 42 warnings
    defconfig+kselftest (gcc-8): 42 warnings

riscv:
    rv32_defconfig (gcc-8): 4 warnings

Errors summary:

    1    clang: error: assembler command failed with exit code 1 (use -v to see invocation)

Warnings summary:

    6    drivers/soc/rockchip/pm_domains.c:832:20: warning: shift count is negative [-Wshift-count-negative]
    6    drivers/soc/rockchip/pm_domains.c:820:21: warning: shift count is negative [-Wshift-count-negative]
    6    drivers/soc/rockchip/pm_domains.c:819:22: warning: shift count is negative [-Wshift-count-negative]
    6    drivers/soc/rockchip/pm_domains.c:818:22: warning: shift count is negative [-Wshift-count-negative]
    4    drivers/soc/rockchip/pm_domains.c:834:21: warning: shift count is negative [-Wshift-count-negative]
    4    drivers/soc/rockchip/pm_domains.c:833:21: warning: shift count is negative [-Wshift-count-negative]
    4    drivers/soc/rockchip/pm_domains.c:822:21: warning: shift count is negative [-Wshift-count-negative]
    4    drivers/soc/rockchip/pm_domains.c:821:21: warning: shift count is negative [-Wshift-count-negative]
    4    drivers/soc/rockchip/pm_domains.c:796:21: warning: shift count is negative [-Wshift-count-negative]
    4    drivers/soc/rockchip/pm_domains.c:795:21: warning: shift count is negative [-Wshift-count-negative]
    4    drivers/soc/rockchip/pm_domains.c:794:21: warning: shift count is negative [-Wshift-count-negative]
    4    drivers/soc/rockchip/pm_domains.c:793:22: warning: shift count is negative [-Wshift-count-negative]
    4    drivers/soc/rockchip/pm_domains.c:792:21: warning: shift count is negative [-Wshift-count-negative]
    4    drivers/soc/rockchip/pm_domains.c:791:21: warning: shift count is negative [-Wshift-count-negative]
    4    drivers/soc/rockchip/pm_domains.c:790:21: warning: shift count is negative [-Wshift-count-negative]
    4    drivers/soc/rockchip/pm_domains.c:789:21: warning: shift count is negative [-Wshift-count-negative]
    4    drivers/soc/rockchip/pm_domains.c:788:21: warning: shift count is negative [-Wshift-count-negative]
    4    drivers/soc/rockchip/pm_domains.c:752:21: warning: shift count is negative [-Wshift-count-negative]
    2    drivers/soc/rockchip/pm_domains.c:747:21: warning: shift count is negative [-Wshift-count-negative]
    2    <stdin>:830:2: warning: #warning syscall fstat64 not implemented [-Wcpp]
    2    <stdin>:1127:2: warning: #warning syscall fstatat64 not implemented [-Wcpp]
    2    41 warnings generated.
    1    arch/arc/mm/tlb.c:914:2: warning: ISO C90 forbids variable length array 'pd0' [-Wvla]
    1    arch/arc/include/asm/cmpxchg.h:95:29: warning: value computed is not used [-Wunused-value]

================================================================================

Detailed per-defconfig build reports:

--------------------------------------------------------------------------------
32r2el_defconfig (mips, gcc-8) — PASS, 0 errors, 0 warnings, 0 section mismatches

--------------------------------------------------------------------------------
defconfig (riscv, gcc-8) — PASS, 0 errors, 0 warnings, 0 section mismatches

--------------------------------------------------------------------------------
defconfig (arm64, gcc-8) — PASS, 0 errors, 0 warnings, 0 section mismatches

--------------------------------------------------------------------------------
defconfig (arm64, clang-8) — PASS, 0 errors, 42 warnings, 0 section mismatches

Warnings:
    drivers/soc/rockchip/pm_domains.c:747:21: warning: shift count is negative [-Wshift-count-negative]
    drivers/soc/rockchip/pm_domains.c:752:21: warning: shift count is negative [-Wshift-count-negative]
    drivers/soc/rockchip/pm_domains.c:752:21: warning: shift count is negative [-Wshift-count-negative]
    drivers/soc/rockchip/pm_domains.c:788:21: warning: shift count is negative [-Wshift-count-negative]
    drivers/soc/rockchip/pm_domains.c:788:21: warning: shift count is negative [-Wshift-count-negative]
    drivers/soc/rockchip/pm_domains.c:789:21: warning: shift count is negative [-Wshift-count-negative]
    drivers/soc/rockchip/pm_domains.c:789:21: warning: shift count is negative [-Wshift-count-negative]
    drivers/soc/rockchip/pm_domains.c:790:21: warning: shift count is negative [-Wshift-count-negative]
    drivers/soc/rockchip/pm_domains.c:790:21: warning: shift count is negative [-Wshift-count-negative]
    drivers/soc/rockchip/pm_domains.c:791:21: warning: shift count is negative [-Wshift-count-negative]
    drivers/soc/rockchip/pm_domains.c:791:21: warning: shift count is negative [-Wshift-count-negative]
    drivers/soc/rockchip/pm_domains.c:792:21: warning: shift count is negative [-Wshift-count-negative]
    drivers/soc/rockchip/pm_domains.c:792:21: warning: shift count is negative [-Wshift-count-negative]
    drivers/soc/rockchip/pm_domains.c:793:22: warning: shift count is negative [-Wshift-count-negative]
    drivers/soc/rockchip/pm_domains.c:793:22: warning: shift count is negative [-Wshift-count-negative]
    drivers/soc/rockchip/pm_domains.c:794:21: warning: shift count is negative [-Wshift-count-negative]
    drivers/soc/rockchip/pm_domains.c:794:21: warning: shift count is negative [-Wshift-count-negative]
    drivers/soc/rockchip/pm_domains.c:795:21: warning: shift count is negative [-Wshift-count-negative]
    drivers/soc/rockchip/pm_domains.c:795:21: warning: shift count is negative [-Wshift-count-negative]
    drivers/soc/rockchip/pm_domains.c:796:21: warning: shift count is negative [-Wshift-count-negative]
    drivers/soc/rockchip/pm_domains.c:796:21: warning: shift count is negative [-Wshift-count-negative]
    drivers/soc/rockchip/pm_domains.c:818:22: warning: shift count is negative [-Wshift-count-negative]
    drivers/soc/rockchip/pm_domains.c:818:22: warning: shift count is negative [-Wshift-count-negative]
    drivers/soc/rockchip/pm_domains.c:818:22: warning: shift count is negative [-Wshift-count-negative]
    drivers/soc/rockchip/pm_domains.c:819:22: warning: shift count is negative [-Wshift-count-negative]
    drivers/soc/rockchip/pm_domains.c:819:22: warning: shift count is negative [-Wshift-count-negative]
    drivers/soc/rockchip/pm_domains.c:819:22: warning: shift count is negative [-Wshift-count-negative]
    drivers/soc/rockchip/pm_domains.c:820:21: warning: shift count is negative [-Wshift-count-negative]
    drivers/soc/rockchip/pm_domains.c:820:21: warning: shift count is negative [-Wshift-count-negative]
    drivers/soc/rockchip/pm_domains.c:820:21: warning: shift count is negative [-Wshift-count-negative]
    drivers/soc/rockchip/pm_domains.c:821:21: warning: shift count is negative [-Wshift-count-negative]
    drivers/soc/rockchip/pm_domains.c:821:21: warning: shift count is negative [-Wshift-count-negative]
    drivers/soc/rockchip/pm_domains.c:822:21: warning: shift count is negative [-Wshift-count-negative]
    drivers/soc/rockchip/pm_domains.c:822:21: warning: shift count is negative [-Wshift-count-negative]
    drivers/soc/rockchip/pm_domains.c:832:20: warning: shift count is negative [-Wshift-count-negative]
    drivers/soc/rockchip/pm_domains.c:832:20: warning: shift count is negative [-Wshift-count-negative]
    drivers/soc/rockchip/pm_domains.c:832:20: warning: shift count is negative [-Wshift-count-negative]
    drivers/soc/rockchip/pm_domains.c:833:21: warning: shift count is negative [-Wshift-count-negative]
    drivers/soc/rockchip/pm_domains.c:833:21: warning: shift count is negative [-Wshift-count-negative]
    drivers/soc/rockchip/pm_domains.c:834:21: warning: shift count is negative [-Wshift-count-negative]
    drivers/soc/rockchip/pm_domains.c:834:21: warning: shift count is negative [-Wshift-count-negative]
    41 warnings generated.

--------------------------------------------------------------------------------
defconfig+kselftest (arm64, gcc-8) — PASS, 0 errors, 0 warnings, 0 section mismatches

--------------------------------------------------------------------------------
defconfig+kselftest (arm64, clang-8) — PASS, 0 errors, 42 warnings, 0 section mismatches

Warnings:
    drivers/soc/rockchip/pm_domains.c:747:21: warning: shift count is negative [-Wshift-count-negative]
    drivers/soc/rockchip/pm_domains.c:752:21: warning: shift count is negative [-Wshift-count-negative]
    drivers/soc/rockchip/pm_domains.c:752:21: warning: shift count is negative [-Wshift-count-negative]
    drivers/soc/rockchip/pm_domains.c:788:21: warning: shift count is negative [-Wshift-count-negative]
    drivers/soc/rockchip/pm_domains.c:788:21: warning: shift count is negative [-Wshift-count-negative]
    drivers/soc/rockchip/pm_domains.c:789:21: warning: shift count is negative [-Wshift-count-negative]
    drivers/soc/rockchip/pm_domains.c:789:21: warning: shift count is negative [-Wshift-count-negative]
    drivers/soc/rockchip/pm_domains.c:790:21: warning: shift count is negative [-Wshift-count-negative]
    drivers/soc/rockchip/pm_domains.c:790:21: warning: shift count is negative [-Wshift-count-negative]
    drivers/soc/rockchip/pm_domains.c:791:21: warning: shift count is negative [-Wshift-count-negative]
    drivers/soc/rockchip/pm_domains.c:791:21: warning: shift count is negative [-Wshift-count-negative]
    drivers/soc/rockchip/pm_domains.c:792:21: warning: shift count is negative [-Wshift-count-negative]
    drivers/soc/rockchip/pm_domains.c:792:21: warning: shift count is negative [-Wshift-count-negative]
    drivers/soc/rockchip/pm_domains.c:793:22: warning: shift count is negative [-Wshift-count-negative]
    drivers/soc/rockchip/pm_domains.c:793:22: warning: shift count is negative [-Wshift-count-negative]
    drivers/soc/rockchip/pm_domains.c:794:21: warning: shift count is negative [-Wshift-count-negative]
    drivers/soc/rockchip/pm_domains.c:794:21: warning: shift count is negative [-Wshift-count-negative]
    drivers/soc/rockchip/pm_domains.c:795:21: warning: shift count is negative [-Wshift-count-negative]
    drivers/soc/rockchip/pm_domains.c:795:21: warning: shift count is negative [-Wshift-count-negative]
    drivers/soc/rockchip/pm_domains.c:796:21: warning: shift count is negative [-Wshift-count-negative]
    drivers/soc/rockchip/pm_domains.c:796:21: warning: shift count is negative [-Wshift-count-negative]
    drivers/soc/rockchip/pm_domains.c:818:22: warning: shift count is negative [-Wshift-count-negative]
    drivers/soc/rockchip/pm_domains.c:818:22: warning: shift count is negative [-Wshift-count-negative]
    drivers/soc/rockchip/pm_domains.c:818:22: warning: shift count is negative [-Wshift-count-negative]
    drivers/soc/rockchip/pm_domains.c:819:22: warning: shift count is negative [-Wshift-count-negative]
    drivers/soc/rockchip/pm_domains.c:819:22: warning: shift count is negative [-Wshift-count-negative]
    drivers/soc/rockchip/pm_domains.c:819:22: warning: shift count is negative [-Wshift-count-negative]
    drivers/soc/rockchip/pm_domains.c:820:21: warning: shift count is negative [-Wshift-count-negative]
    drivers/soc/rockchip/pm_domains.c:820:21: warning: shift count is negative [-Wshift-count-negative]
    drivers/soc/rockchip/pm_domains.c:820:21: warning: shift count is negative [-Wshift-count-negative]
    drivers/soc/rockchip/pm_domains.c:821:21: warning: shift count is negative [-Wshift-count-negative]
    drivers/soc/rockchip/pm_domains.c:821:21: warning: shift count is negative [-Wshift-count-negative]
    drivers/soc/rockchip/pm_domains.c:822:21: warning: shift count is negative [-Wshift-count-negative]
    drivers/soc/rockchip/pm_domains.c:822:21: warning: shift count is negative [-Wshift-count-negative]
    drivers/soc/rockchip/pm_domains.c:832:20: warning: shift count is negative [-Wshift-count-negative]
    drivers/soc/rockchip/pm_domains.c:832:20: warning: shift count is negative [-Wshift-count-negative]
    drivers/soc/rockchip/pm_domains.c:832:20: warning: shift count is negative [-Wshift-count-negative]
    drivers/soc/rockchip/pm_domains.c:833:21: warning: shift count is negative [-Wshift-count-negative]
    drivers/soc/rockchip/pm_domains.c:833:21: warning: shift count is negative [-Wshift-count-negative]
    drivers/soc/rockchip/pm_domains.c:834:21: warning: shift count is negative [-Wshift-count-negative]
    drivers/soc/rockchip/pm_domains.c:834:21: warning: shift count is negative [-Wshift-count-negative]
    41 warnings generated.

--------------------------------------------------------------------------------
multi_v7_defconfig (arm, clang-8) — FAIL, 1 error, 0 warnings, 0 section mismatches

Errors:
    clang: error: assembler command failed with exit code 1 (use -v to see invocation)

--------------------------------------------------------------------------------
multi_v7_defconfig (arm, gcc-8) — PASS, 0 errors, 0 warnings, 0 section mismatches

--------------------------------------------------------------------------------
nsim_hs_defconfig (arc, gcc-8) — PASS, 0 errors, 2 warnings, 0 section mismatches

Warnings:
    arch/arc/mm/tlb.c:914:2: warning: ISO C90 forbids variable length array 'pd0' [-Wvla]
    arch/arc/include/asm/cmpxchg.h:95:29: warning: value computed is not used [-Wunused-value]

--------------------------------------------------------------------------------
rv32_defconfig (riscv, gcc-8) — PASS, 0 errors, 4 warnings, 0 section mismatches

Warnings:
    <stdin>:830:2: warning: #warning syscall fstat64 not implemented [-Wcpp]
    <stdin>:1127:2: warning: #warning syscall fstatat64 not implemented [-Wcpp]
    <stdin>:830:2: warning: #warning syscall fstat64 not implemented [-Wcpp]
    <stdin>:1127:2: warning: #warning syscall fstatat64 not implemented [-Wcpp]

--------------------------------------------------------------------------------
x86_64_defconfig (x86_64, gcc-8) — PASS, 0 errors, 0 warnings, 0 section mismatches

---
For more info write to <info@kernelci.org>

mattface · 2019-05-07T13:18:51Z

So the remaining issue is the warning counts are wrong in the area of the email above the detailed summary. The problem is the data structure used to generate that section of the template is per defconfig, and the warning count is the last processed for a defconfig, ignoring the compiler that was used.

I'm working on this ASAP.

mattface · 2019-05-09T18:38:35Z

As far as I can locally test, this PR is ready for updating onto staging and running tests through.

gctucker · 2019-05-09T18:39:54Z

Sure, this will get tested tomorrow morning, all PRs are tested every day ;)

mattface · 2019-05-09T18:41:45Z

@gctucker is that automated? I was hoping so but wasnt sure if it needed your magic script running. Where is that run btw, and is it in git?

gctucker · 2019-05-09T18:45:52Z

It's not automated, I have a script to pull all the PRs into a branch but the rest is manual. I can explain how that works on IRC if you want.

gctucker · 2019-05-10T10:52:58Z

Tested OK on staging today, the gcc-8 and clang-8 warnings appear to be consistent between the summary and in the detailed sections.

See below today's build email with the changes from this PR for the record.

kernelci/staging.kernelci.org build: 9 builds: 0 failed, 9 passed, 223 warnings (v5.1-9366-g63f731a788f8)

Full Build Summary: https://staging.kernelci.org/build/kernelci/branch/staging.kernelci.org/kernel/v5.1-9366-g63f731a788f8/

Tree: kernelci
Branch: staging.kernelci.org
Git Describe: v5.1-9366-g63f731a788f8
Git Commit: 63f731a788f841ec09560fc0fb44c16a84d0992a
Git URL: https://github.com/kernelci/linux.git
Built: 6 unique architectures

Warnings Detected:

arc:
    nsim_hs_defconfig (gcc-8): 14 warnings

arm64:
    defconfig (gcc-8): 12 warnings
    defconfig (clang-8): 68 warnings

arm:
    multi_v7_defconfig (gcc-8): 12 warnings
    multi_v7_defconfig (clang-8): 70 warnings

mips:
    32r2el_defconfig (gcc-8): 18 warnings

riscv:
    defconfig (gcc-8): 12 warnings
    rv32_defconfig (gcc-8): 16 warnings

x86_64:
    x86_64_defconfig (gcc-8): 1 warning


Warnings summary:

    13   <stdin>:1403:2: warning: #warning syscall fspick not implemented [-Wcpp]
    13   <stdin>:1400:2: warning: #warning syscall fsmount not implemented [-Wcpp]
    13   <stdin>:1397:2: warning: #warning syscall fsconfig not implemented [-Wcpp]
    13   <stdin>:1394:2: warning: #warning syscall fsopen not implemented [-Wcpp]
    13   <stdin>:1391:2: warning: #warning syscall move_mount not implemented [-Wcpp]
    13   <stdin>:1388:2: warning: #warning syscall open_tree not implemented [-Wcpp]
    6    drivers/soc/rockchip/pm_domains.c:832:20: warning: shift count is negative [-Wshift-count-negative]
    6    drivers/soc/rockchip/pm_domains.c:820:21: warning: shift count is negative [-Wshift-count-negative]
    6    drivers/soc/rockchip/pm_domains.c:819:22: warning: shift count is negative [-Wshift-count-negative]
    6    drivers/soc/rockchip/pm_domains.c:818:22: warning: shift count is negative [-Wshift-count-negative]
    4    drivers/soc/rockchip/pm_domains.c:834:21: warning: shift count is negative [-Wshift-count-negative]
    4    drivers/soc/rockchip/pm_domains.c:833:21: warning: shift count is negative [-Wshift-count-negative]
    4    drivers/soc/rockchip/pm_domains.c:822:21: warning: shift count is negative [-Wshift-count-negative]
    4    drivers/soc/rockchip/pm_domains.c:821:21: warning: shift count is negative [-Wshift-count-negative]
    4    drivers/soc/rockchip/pm_domains.c:796:21: warning: shift count is negative [-Wshift-count-negative]
    4    drivers/soc/rockchip/pm_domains.c:795:21: warning: shift count is negative [-Wshift-count-negative]
    4    drivers/soc/rockchip/pm_domains.c:794:21: warning: shift count is negative [-Wshift-count-negative]
    4    drivers/soc/rockchip/pm_domains.c:793:22: warning: shift count is negative [-Wshift-count-negative]
    4    drivers/soc/rockchip/pm_domains.c:792:21: warning: shift count is negative [-Wshift-count-negative]
    4    drivers/soc/rockchip/pm_domains.c:791:21: warning: shift count is negative [-Wshift-count-negative]
    4    drivers/soc/rockchip/pm_domains.c:790:21: warning: shift count is negative [-Wshift-count-negative]
    4    drivers/soc/rockchip/pm_domains.c:789:21: warning: shift count is negative [-Wshift-count-negative]
    4    drivers/soc/rockchip/pm_domains.c:788:21: warning: shift count is negative [-Wshift-count-negative]
    4    drivers/soc/rockchip/pm_domains.c:752:21: warning: shift count is negative [-Wshift-count-negative]
    4    <stdin>:1403:2: warning: syscall fspick not implemented [-W#warnings]
    4    <stdin>:1400:2: warning: syscall fsmount not implemented [-W#warnings]
    4    <stdin>:1397:2: warning: syscall fsconfig not implemented [-W#warnings]
    4    <stdin>:1394:2: warning: syscall fsopen not implemented [-W#warnings]
    4    <stdin>:1391:2: warning: syscall move_mount not implemented [-W#warnings]
    4    <stdin>:1388:2: warning: syscall open_tree not implemented [-W#warnings]
    4    6 warnings generated.
    4    #warning syscall open_tree not implemented
    4    #warning syscall move_mount not implemented
    4    #warning syscall fspick not implemented
    4    #warning syscall fsopen not implemented
    4    #warning syscall fsmount not implemented
    4    #warning syscall fsconfig not implemented
    2    drivers/soc/rockchip/pm_domains.c:747:21: warning: shift count is negative [-Wshift-count-negative]
    2    <stdin>:830:2: warning: #warning syscall fstat64 not implemented [-Wcpp]
    2    <stdin>:1127:2: warning: #warning syscall fstatat64 not implemented [-Wcpp]
    2    41 warnings generated.
    1    fs/select.c:619:5: warning: stack frame size of 1064 bytes in function 'core_sys_select' [-Wframe-larger-than=]
    1    drivers/net/ethernet/marvell/sky2.c:4808:3: warning: argument 2 null where non-null expected [-Wnonnull]
    1    arch/arc/mm/tlb.c:914:2: warning: ISO C90 forbids variable length array 'pd0' [-Wvla]
    1    arch/arc/include/asm/cmpxchg.h:95:29: warning: value computed is not used [-Wunused-value]
    1    1 warning generated.

================================================================================

Detailed per-defconfig build reports:

--------------------------------------------------------------------------------
32r2el_defconfig (mips, gcc-8) — PASS, 0 errors, 18 warnings, 0 section mismatches

Warnings:
    <stdin>:1388:2: warning: #warning syscall open_tree not implemented [-Wcpp]
    <stdin>:1391:2: warning: #warning syscall move_mount not implemented [-Wcpp]
    <stdin>:1394:2: warning: #warning syscall fsopen not implemented [-Wcpp]
    <stdin>:1397:2: warning: #warning syscall fsconfig not implemented [-Wcpp]
    <stdin>:1400:2: warning: #warning syscall fsmount not implemented [-Wcpp]
    <stdin>:1403:2: warning: #warning syscall fspick not implemented [-Wcpp]
    <stdin>:1388:2: warning: #warning syscall open_tree not implemented [-Wcpp]
    <stdin>:1391:2: warning: #warning syscall move_mount not implemented [-Wcpp]
    <stdin>:1394:2: warning: #warning syscall fsopen not implemented [-Wcpp]
    <stdin>:1397:2: warning: #warning syscall fsconfig not implemented [-Wcpp]
    <stdin>:1400:2: warning: #warning syscall fsmount not implemented [-Wcpp]
    <stdin>:1403:2: warning: #warning syscall fspick not implemented [-Wcpp]
    <stdin>:1388:2: warning: #warning syscall open_tree not implemented [-Wcpp]
    <stdin>:1391:2: warning: #warning syscall move_mount not implemented [-Wcpp]
    <stdin>:1394:2: warning: #warning syscall fsopen not implemented [-Wcpp]
    <stdin>:1397:2: warning: #warning syscall fsconfig not implemented [-Wcpp]
    <stdin>:1400:2: warning: #warning syscall fsmount not implemented [-Wcpp]
    <stdin>:1403:2: warning: #warning syscall fspick not implemented [-Wcpp]

--------------------------------------------------------------------------------
defconfig (riscv, gcc-8) — PASS, 0 errors, 12 warnings, 0 section mismatches

Warnings:
    <stdin>:1388:2: warning: #warning syscall open_tree not implemented [-Wcpp]
    <stdin>:1391:2: warning: #warning syscall move_mount not implemented [-Wcpp]
    <stdin>:1394:2: warning: #warning syscall fsopen not implemented [-Wcpp]
    <stdin>:1397:2: warning: #warning syscall fsconfig not implemented [-Wcpp]
    <stdin>:1400:2: warning: #warning syscall fsmount not implemented [-Wcpp]
    <stdin>:1403:2: warning: #warning syscall fspick not implemented [-Wcpp]
    <stdin>:1388:2: warning: #warning syscall open_tree not implemented [-Wcpp]
    <stdin>:1391:2: warning: #warning syscall move_mount not implemented [-Wcpp]
    <stdin>:1394:2: warning: #warning syscall fsopen not implemented [-Wcpp]
    <stdin>:1397:2: warning: #warning syscall fsconfig not implemented [-Wcpp]
    <stdin>:1400:2: warning: #warning syscall fsmount not implemented [-Wcpp]
    <stdin>:1403:2: warning: #warning syscall fspick not implemented [-Wcpp]

--------------------------------------------------------------------------------
defconfig (arm64, gcc-8) — PASS, 0 errors, 12 warnings, 0 section mismatches

Warnings:
    <stdin>:1388:2: warning: #warning syscall open_tree not implemented [-Wcpp]
    <stdin>:1391:2: warning: #warning syscall move_mount not implemented [-Wcpp]
    <stdin>:1394:2: warning: #warning syscall fsopen not implemented [-Wcpp]
    <stdin>:1397:2: warning: #warning syscall fsconfig not implemented [-Wcpp]
    <stdin>:1400:2: warning: #warning syscall fsmount not implemented [-Wcpp]
    <stdin>:1403:2: warning: #warning syscall fspick not implemented [-Wcpp]
    <stdin>:1388:2: warning: #warning syscall open_tree not implemented [-Wcpp]
    <stdin>:1391:2: warning: #warning syscall move_mount not implemented [-Wcpp]
    <stdin>:1394:2: warning: #warning syscall fsopen not implemented [-Wcpp]
    <stdin>:1397:2: warning: #warning syscall fsconfig not implemented [-Wcpp]
    <stdin>:1400:2: warning: #warning syscall fsmount not implemented [-Wcpp]
    <stdin>:1403:2: warning: #warning syscall fspick not implemented [-Wcpp]

--------------------------------------------------------------------------------
defconfig (arm64, clang-8) — PASS, 0 errors, 68 warnings, 0 section mismatches

Warnings:
    <stdin>:1388:2: warning: syscall open_tree not implemented [-W#warnings]
    #warning syscall open_tree not implemented
    <stdin>:1391:2: warning: syscall move_mount not implemented [-W#warnings]
    #warning syscall move_mount not implemented
    <stdin>:1394:2: warning: syscall fsopen not implemented [-W#warnings]
    #warning syscall fsopen not implemented
    <stdin>:1397:2: warning: syscall fsconfig not implemented [-W#warnings]
    #warning syscall fsconfig not implemented
    <stdin>:1400:2: warning: syscall fsmount not implemented [-W#warnings]
    #warning syscall fsmount not implemented
    <stdin>:1403:2: warning: syscall fspick not implemented [-W#warnings]
    #warning syscall fspick not implemented
    6 warnings generated.
    drivers/soc/rockchip/pm_domains.c:747:21: warning: shift count is negative [-Wshift-count-negative]
    drivers/soc/rockchip/pm_domains.c:752:21: warning: shift count is negative [-Wshift-count-negative]
    drivers/soc/rockchip/pm_domains.c:752:21: warning: shift count is negative [-Wshift-count-negative]
    drivers/soc/rockchip/pm_domains.c:788:21: warning: shift count is negative [-Wshift-count-negative]
    drivers/soc/rockchip/pm_domains.c:788:21: warning: shift count is negative [-Wshift-count-negative]
    drivers/soc/rockchip/pm_domains.c:789:21: warning: shift count is negative [-Wshift-count-negative]
    drivers/soc/rockchip/pm_domains.c:789:21: warning: shift count is negative [-Wshift-count-negative]
    drivers/soc/rockchip/pm_domains.c:790:21: warning: shift count is negative [-Wshift-count-negative]
    drivers/soc/rockchip/pm_domains.c:790:21: warning: shift count is negative [-Wshift-count-negative]
    drivers/soc/rockchip/pm_domains.c:791:21: warning: shift count is negative [-Wshift-count-negative]
    drivers/soc/rockchip/pm_domains.c:791:21: warning: shift count is negative [-Wshift-count-negative]
    drivers/soc/rockchip/pm_domains.c:792:21: warning: shift count is negative [-Wshift-count-negative]
    drivers/soc/rockchip/pm_domains.c:792:21: warning: shift count is negative [-Wshift-count-negative]
    drivers/soc/rockchip/pm_domains.c:793:22: warning: shift count is negative [-Wshift-count-negative]
    drivers/soc/rockchip/pm_domains.c:793:22: warning: shift count is negative [-Wshift-count-negative]
    drivers/soc/rockchip/pm_domains.c:794:21: warning: shift count is negative [-Wshift-count-negative]
    drivers/soc/rockchip/pm_domains.c:794:21: warning: shift count is negative [-Wshift-count-negative]
    drivers/soc/rockchip/pm_domains.c:795:21: warning: shift count is negative [-Wshift-count-negative]
    drivers/soc/rockchip/pm_domains.c:795:21: warning: shift count is negative [-Wshift-count-negative]
    drivers/soc/rockchip/pm_domains.c:796:21: warning: shift count is negative [-Wshift-count-negative]
    drivers/soc/rockchip/pm_domains.c:796:21: warning: shift count is negative [-Wshift-count-negative]
    drivers/soc/rockchip/pm_domains.c:818:22: warning: shift count is negative [-Wshift-count-negative]
    drivers/soc/rockchip/pm_domains.c:818:22: warning: shift count is negative [-Wshift-count-negative]
    drivers/soc/rockchip/pm_domains.c:818:22: warning: shift count is negative [-Wshift-count-negative]
    drivers/soc/rockchip/pm_domains.c:819:22: warning: shift count is negative [-Wshift-count-negative]
    drivers/soc/rockchip/pm_domains.c:819:22: warning: shift count is negative [-Wshift-count-negative]
    drivers/soc/rockchip/pm_domains.c:819:22: warning: shift count is negative [-Wshift-count-negative]
    drivers/soc/rockchip/pm_domains.c:820:21: warning: shift count is negative [-Wshift-count-negative]
    drivers/soc/rockchip/pm_domains.c:820:21: warning: shift count is negative [-Wshift-count-negative]
    drivers/soc/rockchip/pm_domains.c:820:21: warning: shift count is negative [-Wshift-count-negative]
    drivers/soc/rockchip/pm_domains.c:821:21: warning: shift count is negative [-Wshift-count-negative]
    drivers/soc/rockchip/pm_domains.c:821:21: warning: shift count is negative [-Wshift-count-negative]
    drivers/soc/rockchip/pm_domains.c:822:21: warning: shift count is negative [-Wshift-count-negative]
    drivers/soc/rockchip/pm_domains.c:822:21: warning: shift count is negative [-Wshift-count-negative]
    drivers/soc/rockchip/pm_domains.c:832:20: warning: shift count is negative [-Wshift-count-negative]
    drivers/soc/rockchip/pm_domains.c:832:20: warning: shift count is negative [-Wshift-count-negative]
    drivers/soc/rockchip/pm_domains.c:832:20: warning: shift count is negative [-Wshift-count-negative]
    drivers/soc/rockchip/pm_domains.c:833:21: warning: shift count is negative [-Wshift-count-negative]
    drivers/soc/rockchip/pm_domains.c:833:21: warning: shift count is negative [-Wshift-count-negative]
    drivers/soc/rockchip/pm_domains.c:834:21: warning: shift count is negative [-Wshift-count-negative]
    drivers/soc/rockchip/pm_domains.c:834:21: warning: shift count is negative [-Wshift-count-negative]
    41 warnings generated.
    <stdin>:1388:2: warning: syscall open_tree not implemented [-W#warnings]
    #warning syscall open_tree not implemented
    <stdin>:1391:2: warning: syscall move_mount not implemented [-W#warnings]
    #warning syscall move_mount not implemented
    <stdin>:1394:2: warning: syscall fsopen not implemented [-W#warnings]
    #warning syscall fsopen not implemented
    <stdin>:1397:2: warning: syscall fsconfig not implemented [-W#warnings]
    #warning syscall fsconfig not implemented
    <stdin>:1400:2: warning: syscall fsmount not implemented [-W#warnings]
    #warning syscall fsmount not implemented
    <stdin>:1403:2: warning: syscall fspick not implemented [-W#warnings]
    #warning syscall fspick not implemented
    6 warnings generated.

--------------------------------------------------------------------------------
multi_v7_defconfig (arm, gcc-8) — PASS, 0 errors, 12 warnings, 0 section mismatches

Warnings:
    <stdin>:1388:2: warning: #warning syscall open_tree not implemented [-Wcpp]
    <stdin>:1391:2: warning: #warning syscall move_mount not implemented [-Wcpp]
    <stdin>:1394:2: warning: #warning syscall fsopen not implemented [-Wcpp]
    <stdin>:1397:2: warning: #warning syscall fsconfig not implemented [-Wcpp]
    <stdin>:1400:2: warning: #warning syscall fsmount not implemented [-Wcpp]
    <stdin>:1403:2: warning: #warning syscall fspick not implemented [-Wcpp]
    <stdin>:1388:2: warning: #warning syscall open_tree not implemented [-Wcpp]
    <stdin>:1391:2: warning: #warning syscall move_mount not implemented [-Wcpp]
    <stdin>:1394:2: warning: #warning syscall fsopen not implemented [-Wcpp]
    <stdin>:1397:2: warning: #warning syscall fsconfig not implemented [-Wcpp]
    <stdin>:1400:2: warning: #warning syscall fsmount not implemented [-Wcpp]
    <stdin>:1403:2: warning: #warning syscall fspick not implemented [-Wcpp]

--------------------------------------------------------------------------------
multi_v7_defconfig (arm, clang-8) — PASS, 0 errors, 70 warnings, 0 section mismatches

Warnings:
    <stdin>:1388:2: warning: syscall open_tree not implemented [-W#warnings]
    #warning syscall open_tree not implemented
    <stdin>:1391:2: warning: syscall move_mount not implemented [-W#warnings]
    #warning syscall move_mount not implemented
    <stdin>:1394:2: warning: syscall fsopen not implemented [-W#warnings]
    #warning syscall fsopen not implemented
    <stdin>:1397:2: warning: syscall fsconfig not implemented [-W#warnings]
    #warning syscall fsconfig not implemented
    <stdin>:1400:2: warning: syscall fsmount not implemented [-W#warnings]
    #warning syscall fsmount not implemented
    <stdin>:1403:2: warning: syscall fspick not implemented [-W#warnings]
    #warning syscall fspick not implemented
    6 warnings generated.
    fs/select.c:619:5: warning: stack frame size of 1064 bytes in function 'core_sys_select' [-Wframe-larger-than=]
    1 warning generated.
    drivers/soc/rockchip/pm_domains.c:747:21: warning: shift count is negative [-Wshift-count-negative]
    drivers/soc/rockchip/pm_domains.c:752:21: warning: shift count is negative [-Wshift-count-negative]
    drivers/soc/rockchip/pm_domains.c:752:21: warning: shift count is negative [-Wshift-count-negative]
    drivers/soc/rockchip/pm_domains.c:788:21: warning: shift count is negative [-Wshift-count-negative]
    drivers/soc/rockchip/pm_domains.c:788:21: warning: shift count is negative [-Wshift-count-negative]
    drivers/soc/rockchip/pm_domains.c:789:21: warning: shift count is negative [-Wshift-count-negative]
    drivers/soc/rockchip/pm_domains.c:789:21: warning: shift count is negative [-Wshift-count-negative]
    drivers/soc/rockchip/pm_domains.c:790:21: warning: shift count is negative [-Wshift-count-negative]
    drivers/soc/rockchip/pm_domains.c:790:21: warning: shift count is negative [-Wshift-count-negative]
    drivers/soc/rockchip/pm_domains.c:791:21: warning: shift count is negative [-Wshift-count-negative]
    drivers/soc/rockchip/pm_domains.c:791:21: warning: shift count is negative [-Wshift-count-negative]
    drivers/soc/rockchip/pm_domains.c:792:21: warning: shift count is negative [-Wshift-count-negative]
    drivers/soc/rockchip/pm_domains.c:792:21: warning: shift count is negative [-Wshift-count-negative]
    drivers/soc/rockchip/pm_domains.c:793:22: warning: shift count is negative [-Wshift-count-negative]
    drivers/soc/rockchip/pm_domains.c:793:22: warning: shift count is negative [-Wshift-count-negative]
    drivers/soc/rockchip/pm_domains.c:794:21: warning: shift count is negative [-Wshift-count-negative]
    drivers/soc/rockchip/pm_domains.c:794:21: warning: shift count is negative [-Wshift-count-negative]
    drivers/soc/rockchip/pm_domains.c:795:21: warning: shift count is negative [-Wshift-count-negative]
    drivers/soc/rockchip/pm_domains.c:795:21: warning: shift count is negative [-Wshift-count-negative]
    drivers/soc/rockchip/pm_domains.c:796:21: warning: shift count is negative [-Wshift-count-negative]
    drivers/soc/rockchip/pm_domains.c:796:21: warning: shift count is negative [-Wshift-count-negative]
    drivers/soc/rockchip/pm_domains.c:818:22: warning: shift count is negative [-Wshift-count-negative]
    drivers/soc/rockchip/pm_domains.c:818:22: warning: shift count is negative [-Wshift-count-negative]
    drivers/soc/rockchip/pm_domains.c:818:22: warning: shift count is negative [-Wshift-count-negative]
    drivers/soc/rockchip/pm_domains.c:819:22: warning: shift count is negative [-Wshift-count-negative]
    drivers/soc/rockchip/pm_domains.c:819:22: warning: shift count is negative [-Wshift-count-negative]
    drivers/soc/rockchip/pm_domains.c:819:22: warning: shift count is negative [-Wshift-count-negative]
    drivers/soc/rockchip/pm_domains.c:820:21: warning: shift count is negative [-Wshift-count-negative]
    drivers/soc/rockchip/pm_domains.c:820:21: warning: shift count is negative [-Wshift-count-negative]
    drivers/soc/rockchip/pm_domains.c:820:21: warning: shift count is negative [-Wshift-count-negative]
    drivers/soc/rockchip/pm_domains.c:821:21: warning: shift count is negative [-Wshift-count-negative]
    drivers/soc/rockchip/pm_domains.c:821:21: warning: shift count is negative [-Wshift-count-negative]
    drivers/soc/rockchip/pm_domains.c:822:21: warning: shift count is negative [-Wshift-count-negative]
    drivers/soc/rockchip/pm_domains.c:822:21: warning: shift count is negative [-Wshift-count-negative]
    drivers/soc/rockchip/pm_domains.c:832:20: warning: shift count is negative [-Wshift-count-negative]
    drivers/soc/rockchip/pm_domains.c:832:20: warning: shift count is negative [-Wshift-count-negative]
    drivers/soc/rockchip/pm_domains.c:832:20: warning: shift count is negative [-Wshift-count-negative]
    drivers/soc/rockchip/pm_domains.c:833:21: warning: shift count is negative [-Wshift-count-negative]
    drivers/soc/rockchip/pm_domains.c:833:21: warning: shift count is negative [-Wshift-count-negative]
    drivers/soc/rockchip/pm_domains.c:834:21: warning: shift count is negative [-Wshift-count-negative]
    drivers/soc/rockchip/pm_domains.c:834:21: warning: shift count is negative [-Wshift-count-negative]
    41 warnings generated.
    <stdin>:1388:2: warning: syscall open_tree not implemented [-W#warnings]
    #warning syscall open_tree not implemented
    <stdin>:1391:2: warning: syscall move_mount not implemented [-W#warnings]
    #warning syscall move_mount not implemented
    <stdin>:1394:2: warning: syscall fsopen not implemented [-W#warnings]
    #warning syscall fsopen not implemented
    <stdin>:1397:2: warning: syscall fsconfig not implemented [-W#warnings]
    #warning syscall fsconfig not implemented
    <stdin>:1400:2: warning: syscall fsmount not implemented [-W#warnings]
    #warning syscall fsmount not implemented
    <stdin>:1403:2: warning: syscall fspick not implemented [-W#warnings]
    #warning syscall fspick not implemented
    6 warnings generated.

--------------------------------------------------------------------------------
nsim_hs_defconfig (arc, gcc-8) — PASS, 0 errors, 14 warnings, 0 section mismatches

Warnings:
    <stdin>:1388:2: warning: #warning syscall open_tree not implemented [-Wcpp]
    <stdin>:1391:2: warning: #warning syscall move_mount not implemented [-Wcpp]
    <stdin>:1394:2: warning: #warning syscall fsopen not implemented [-Wcpp]
    <stdin>:1397:2: warning: #warning syscall fsconfig not implemented [-Wcpp]
    <stdin>:1400:2: warning: #warning syscall fsmount not implemented [-Wcpp]
    <stdin>:1403:2: warning: #warning syscall fspick not implemented [-Wcpp]
    arch/arc/mm/tlb.c:914:2: warning: ISO C90 forbids variable length array 'pd0' [-Wvla]
    arch/arc/include/asm/cmpxchg.h:95:29: warning: value computed is not used [-Wunused-value]
    <stdin>:1388:2: warning: #warning syscall open_tree not implemented [-Wcpp]
    <stdin>:1391:2: warning: #warning syscall move_mount not implemented [-Wcpp]
    <stdin>:1394:2: warning: #warning syscall fsopen not implemented [-Wcpp]
    <stdin>:1397:2: warning: #warning syscall fsconfig not implemented [-Wcpp]
    <stdin>:1400:2: warning: #warning syscall fsmount not implemented [-Wcpp]
    <stdin>:1403:2: warning: #warning syscall fspick not implemented [-Wcpp]

--------------------------------------------------------------------------------
rv32_defconfig (riscv, gcc-8) — PASS, 0 errors, 16 warnings, 0 section mismatches

Warnings:
    <stdin>:830:2: warning: #warning syscall fstat64 not implemented [-Wcpp]
    <stdin>:1127:2: warning: #warning syscall fstatat64 not implemented [-Wcpp]
    <stdin>:1388:2: warning: #warning syscall open_tree not implemented [-Wcpp]
    <stdin>:1391:2: warning: #warning syscall move_mount not implemented [-Wcpp]
    <stdin>:1394:2: warning: #warning syscall fsopen not implemented [-Wcpp]
    <stdin>:1397:2: warning: #warning syscall fsconfig not implemented [-Wcpp]
    <stdin>:1400:2: warning: #warning syscall fsmount not implemented [-Wcpp]
    <stdin>:1403:2: warning: #warning syscall fspick not implemented [-Wcpp]
    <stdin>:830:2: warning: #warning syscall fstat64 not implemented [-Wcpp]
    <stdin>:1127:2: warning: #warning syscall fstatat64 not implemented [-Wcpp]
    <stdin>:1388:2: warning: #warning syscall open_tree not implemented [-Wcpp]
    <stdin>:1391:2: warning: #warning syscall move_mount not implemented [-Wcpp]
    <stdin>:1394:2: warning: #warning syscall fsopen not implemented [-Wcpp]
    <stdin>:1397:2: warning: #warning syscall fsconfig not implemented [-Wcpp]
    <stdin>:1400:2: warning: #warning syscall fsmount not implemented [-Wcpp]
    <stdin>:1403:2: warning: #warning syscall fspick not implemented [-Wcpp]

--------------------------------------------------------------------------------
x86_64_defconfig (x86_64, gcc-8) — PASS, 0 errors, 1 warning, 0 section mismatches

Warnings:
    drivers/net/ethernet/marvell/sky2.c:4808:3: warning: argument 2 null where non-null expected [-Wnonnull]

---
For more info write to <info@kernelci.org>

gctucker

This seems to be functionally correct but please rework the patches to remove the WIP and make it easier to review each individual patch.

mattface · 2019-05-10T11:07:02Z

The WIP commit undid a lot of the changes in the previous one so it seemed best to squash them together.

gctucker · 2019-05-10T11:12:45Z

The WIP commit undid a lot of the changes in the previous one so it seemed best to squash them together.

OK, well please do that and then update the PR.

gctucker · 2019-05-10T11:13:19Z

The WIP commit undid a lot of the changes in the previous one so it seemed best to squash them together.

OK, well please do that and then update the PR.

Ah sorry you just did that :)

gctucker · 2019-05-10T11:19:32Z

Err, all the pep8 errors that the 2nd commit fixes were introduced in the 1st commit...

mattface · 2019-05-10T11:23:12Z

Good point, have just squashed them in as well.

gctucker

A couple of small things.

Remove the compiler string per arch and instead report an environment for each build result. Use the same way of generating the "failed" data, to generate the error and warnings data. This makes rendering build emails simpler.

mattface · 2019-05-10T13:51:27Z

Fixed, I wasnt aware they existed

gctucker · 2019-05-10T14:33:40Z

Thanks, I've updated the backend staging branch and generated one build email, looks fine.

mattface requested a review from gctucker April 26, 2019 10:19

mattface force-pushed the build-emails branch from 44f0b18 to a50f6f7 Compare May 2, 2019 20:13

mattface force-pushed the build-emails branch from a50f6f7 to 5bc700c Compare May 9, 2019 18:35

gctucker suggested changes May 10, 2019

View reviewed changes

mattface force-pushed the build-emails branch from 5bc700c to 2afccdb Compare May 10, 2019 11:04

mattface force-pushed the build-emails branch from 2afccdb to 6aecca6 Compare May 10, 2019 11:22

gctucker reviewed May 10, 2019

View reviewed changes

Comment thread app/utils/report/build.py Outdated

Comment thread app/utils/report/build.py Outdated

Fix build emails blaiming wrong compiler

c531702

Remove the compiler string per arch and instead report an environment for each build result. Use the same way of generating the "failed" data, to generate the error and warnings data. This makes rendering build emails simpler.

mattface force-pushed the build-emails branch from 6aecca6 to c531702 Compare May 10, 2019 13:37

gctucker approved these changes May 10, 2019

View reviewed changes

gctucker merged commit 472c741 into kernelci:master May 10, 2019

Uh oh!

Conversation

mattface commented Apr 26, 2019

Uh oh!

mattface commented Apr 29, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

nickdesaulniers commented Apr 30, 2019

Uh oh!

gctucker commented May 1, 2019

Uh oh!

gctucker commented May 3, 2019

Uh oh!

mattface commented May 7, 2019

Uh oh!

mattface commented May 9, 2019

Uh oh!

gctucker commented May 9, 2019

Uh oh!

mattface commented May 9, 2019

Uh oh!

gctucker commented May 9, 2019

Uh oh!

gctucker commented May 10, 2019

Uh oh!

gctucker left a comment

Choose a reason for hiding this comment

Uh oh!

mattface commented May 10, 2019

Uh oh!

gctucker commented May 10, 2019

Uh oh!

gctucker commented May 10, 2019

Uh oh!

gctucker commented May 10, 2019

Uh oh!

mattface commented May 10, 2019

Uh oh!

gctucker left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

mattface commented May 10, 2019

Uh oh!

gctucker commented May 10, 2019

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

mattface commented Apr 29, 2019 •

edited

Loading