config/core: rename early-access entries#2638
Merged
nuclearcat merged 1 commit intoNov 25, 2024
Merged
Conversation
Rename configurations for `early-access` to `production`. Early access instance was setup for the initial release phase. It's been used as production now. Signed-off-by: Jeny Sadadia <jeny.sadadia@collabora.com>
JenySadadia
added
the
staging-skip
Collaborator
Author
|
@nuclearcat Should we also update this https://github.com/kernelci/kernelci-core/blob/main/config/runtime/base/kubernetes.jinja2#L58 ? |
JenySadadia
removed
the
staging-skip
pawiecz
approved these changes
Nov 19, 2024
pawiecz
left a comment
pawiecz
left a comment
Collaborator
There was a problem hiding this comment.
This patch LGTM
I'd wait with merging it to e.g. next prod update on Monday to:
- Announce the rename on weekly community meeting
- Give some time to adjust client configs
- Replace all the
early-accessmentions in docs
Collaborator
I'd go for it for consistency. It would also require changing It could be done separately of this PR (as a next step) |
Collaborator
Author
Thanks for pointing this out. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rename configurations for
early-accesstoproduction. Early access instance was setup for the initial release phase. It's been used as production now.