ci: guard updates for missing submodules#571
Merged
Merged
Conversation
Collaborator
|
Hi @nuclearcat Thanks for this. Do you want to add your SOB to the commit? |
Collaborator
|
/staging |
|
Your PR has been deployed to staging. Staging URL: https://static.staging.kernelci.org/ After testing, you can merge your PR. Note: This is a temporary staging URL, if anyone else will test another PR, it will override contents. |
Signed-off-by: Denys Fedoryshchenko <denys.f@collabora.com>
nuclearcat
force-pushed
the
agent/guard-missing-submodules
branch
from
July 16, 2026 14:01
0e52db0 to
ba5fa58
Compare
nuclearcat
marked this pull request as ready for review
July 16, 2026 14:03
Member
Author
|
I think it will refuse to touch/test workflows changes, i will merge as is and test another PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
Guard each external-submodule update so it only runs when the checked-out
submodule has its own
.gitmarker.Why
issue_commentworkflows are loaded from the default branch, then the jobchecks out the pull request head. A pull request that removes a submodule can
therefore run the older default-branch workflow against a tree where that
submodule no longer exists.
This caused staging deployment run 29489094118 to fail while trying to enter
kernelci.org/external/kernelci-core;kcidbwould have failed next.Impact
Existing submodules continue to update from their
mainbranches. Removed oruninitialized submodules are skipped, allowing submodule-removal pull requests
to use the staging deployment workflow safely.
Validation
.github/workflows/deploy.ymlwith PyYAML.git diff --check.