net/proto-vsock.c: fix build on older distros#57
Merged
Conversation
Older distros do not include sys/socket.h -- added only by commit
22bbc1dcd0d6 ("vsock/uapi: fix linux/vm_sockets.h userspace compilation
errors") upstream.
So the build fails with:
In file included from net/proto-vsock.c:3:
/usr/include/linux/vm_sockets.h:182:39: error: invalid application of ‘sizeof’ to incomplete type ‘struct sockaddr’
182 | unsigned char svm_zero[sizeof(struct sockaddr) -
| ^~~~~~
/usr/include/linux/vm_sockets.h:183:39: error: ‘sa_family_t’ undeclared here (not in a function)
183 | sizeof(sa_family_t) -
| ^~~~~~~~~~~
Include the file before vm_sockets.h.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Older distros do not include
sys/socket.h-- added only by commit 22bbc1dcd0d6 ("vsock/uapi: fix linux/vm_sockets.h userspace compilation errors") upstream.So the build fails with:
Include the file before
vm_sockets.h.