refactor: start replacing vuex with pinia #8430
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
elevatebart
changed the title
elevatebart
changed the title
Member
|
since you said it's a PoC, should this be a draft PR or ready for review and merge? |
Contributor
Author
|
PLus I still need to repair the tests and present my findings to the team. |
AcevedoR
reviewed
Jun 17, 2025
AcevedoR
approved these changes
Jun 19, 2025
Contributor
AcevedoR
left a comment
AcevedoR
left a comment
There was a problem hiding this comment.
nice job 💪, this will greatly improve readability, maintainability, and newcomers onboarding
elevatebart
added a commit
that referenced
this pull request
Jun 19, 2025
This reverts commit 9c052c0.
elevatebart
added a commit
that referenced
this pull request
Jun 19, 2025
This reverts commit 1e55003.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR installs pinia in the repo and migrate
api.jsandplugins.jsstores to the new pattern as an example/POCIt brings typescript intellisense and type safety to even the options API! Great!
It does not significantly change the structure of the stores! Great!
🎉