Keep urgent accent on completed notes with dimmed opacity - #76
Merged
Conversation
A note that was both important (urgent) and done lost its accent-red outline: isActivated was gated on `entry.urgent && !entry.done`, so completing an important note dropped it back to the neutral hairline and the "important" highlight vanished. Drive the outline off `entry.urgent` alone so the red border is retained in the done state. The box already dims to half opacity when done, which now also softens the red border — so a done+important note reads as coloured-but-muted rather than losing the highlight entirely. Applies to text, image and voice notes (shared active box) across both the notes list and the notes search screen. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Y6RoTAmTTQi2Lm5oFqT3Dy
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Updates the visual treatment of completed urgent notes to maintain their accent-red outline while dimming the entire box to signal completion, rather than removing the accent color when done.
Changes
NotesAdapter.kt: Changed the logic for applying the urgent accent highlightactiveBox.isActivated = entry.urgent && !entry.done— accent was removed when a note was marked completeactiveBox.isActivated = entry.urgent— accent persists regardless of completion statealpha = 0.5f), which dims both the text and the red border togetherImplementation Details
This change improves the visual hierarchy by:
The updated comment clarifies that the accent survives into the done state, providing better visual continuity for urgent items throughout their lifecycle.
https://claude.ai/code/session_01Y6RoTAmTTQi2Lm5oFqT3Dy