Fix infinite YaraScan loop when dump limit is reached - #186
Merged
Conversation
Owner
|
This is actually causing failures in, for example, dynamic config extraction. Do you have an example sample that triggers the described infinite loop? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes a bug in
ProcessTrackedRegionwhere hitting the dump limit preventedPagesDumpedfrom being set toTRUE. This bypassed entropy thresholds and caused an infinite loop of failed memory dumping and YARA scanning upon every intercepted call.Tested locally, loop no longer triggers.