Fixed bunch of stuff#41
Merged
Merged
Conversation
- Make RateLimitInterceptor open for subclassing in tests - Add '.bin' extension support for Sega Genesis definition - Restrict ROM scan deletions to non-Android platforms only - Explicitly handle empty paths cleanup for both ROM and Android scans - Reuse existing mapping IDs in EmulatorRepositoryImpl.upsertMapping - Fix a fragile assertion in ScanRomsUseCaseTest Co-authored-by: aarvsn <234900867+aarvsn@users.noreply.github.com>
Fix database cleanup, emulator mapping upsert, and test issues
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Key fixes:
Resolved compilation failure in RateLimitInterceptorTest by declaring RateLimitInterceptor open.
Prevented the ROM scanner from purging all installed Android games from the database.
Handled empty-directory scan cleanup explicitly in both ROM and Android app scanners.
Added the '.bin' extension to Sega Genesis system definitions.
Fixed SQLite UNIQUE constraint failures on platform_id when saving custom emulator configurations with an empty/unset ID.