deps#29265
Merged
Merged
Conversation
chrisnojima
merged commit f8ee6cb
into
nojima/HOTPOT-next-670-clean-2
1 check was pending
chrisnojima
added a commit
that referenced
this pull request
May 30, 2026
* clickablebox 3 - teams (#29265) * clickablebox 3 - team-building (#29265) * clickablebox 3 - fs (#29265) * only pick up the folders from shared * fix profile dropdown button full-width regression on mobile (#29265) * fix fs sort button content-sizing regression on desktop (#29265) * fix fs path-item header and destination-picker full-width regression on mobile (#29265) * update migrate-clickable-box skill with fullWidth gotchas (#29265) * cb3 5 (#29267) * migrate shared/chat/ ClickableBox/CB2 → CB3 * migrate shared/common-adapters/ ClickableBox/CB2 → CB3 * complete ClickableBox3 migration: remove legacy CB1/CB2 exports * WIP * fixes * Fix info panel tabs: natural width, centered text, divider spans full tab width * WIP * fix prove-your dialog items to be full width Without fullWidth={true}, ClickableBox3 gets alignSelf:center applied, centering each provider row instead of spanning the modal width. * fix CardListItem body text centering: add fullWidth to body Box2 Nested Box2 direction="vertical" without fullWidth gets box2_centered (align-self:center) applied, horizontally centering it within its column flex parent. Fixed across all CardListItem callers and in list-item.tsx's body wrapper. * remove ChoiceList/RichButton, replace usages with ListItem Card * remove ClickableBox/ClickableBox2 and migration plan — all usages migrated to ClickableBox3 * mass clean (#29268) * simplify-ui: git/ — remove redundant wrappers, dead styles/comments, normalize patterns * simplify-ui: devices/ — deduplicate icon logic, extract constants, replace style props * simplify-ui: wallets/ — rename Container, extract shared styles, remove redundant props * simplify-ui: tracker/ — fix hover-opacity typo, dedup utilities, rename Container, replace flexShrink props * simplify-ui: settings/ — remove redundant wrappers, move styles to props, clean dead code * simplify-ui: crypto/ — inline IIFEs, merge imports, clean up style props and names * simplify-ui: teams/ — merge styles, fix functions-as-values, extract string constants, remove wrappers * simplify-ui: signup/ — extract shared input width, fix prop shorthands, remove dead code * simplify-ui: people/ — remove identity maps, dead code, inline wrappers, move style props * simplify-ui: profile/ — remove dead code, dedup styles, replace Kb shims, noShrink props * address PR feedback: safe nav in async callback, fix avatar overlay positioning, restore .tsx extension * simplify-ui: full codebase pass — rename Containers, remove dead code, move style props Ran simplify-ui-section skill across all UI directories via parallel subagents: chat/, common-adapters/, fs/, login/, provision/, team-building/, unlock-folders/, menubar/, pinentry/, incoming-share/, deeplinks/, router-v2/, and revisits of profile/, people/, signup/, crypto/, teams/, settings/, tracker/, wallets/, devices/, git/. * fix back button hover area: remove inline-block and size(14) from iconContainer The 14×14px fixed size caused the hover highlight to appear only in the upper-left corner while the icon extended beyond it. The container now sizes naturally around the icon with padding defining the hit area. * fix Checkbox centering: add alignSelf=flex-start to ClickableBox3 * WIP * fix iOS e2e: restore testID on mobile crypto nav rows The RichButton→ListItem migration dropped testID; wrap ListItem in Box2 to carry it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.