cb3 4#29266
Merged
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This PR continues the migration from ClickableBox to ClickableBox3, primarily across teams, team-building, and FS UI surfaces, while documenting additional migration gotchas and updating the migration plan.
Changes:
- Replaced many
ClickableBox+ innerBox2wrappers withClickableBox3carrying layout props directly. - Updated
ClickableBox3’sonClicktype to allow an optional event and adjusted several stop-propagation handlers. - Tightened Metro block list regexes to be rooted under the shared project directory.
Reviewed changes
Copilot reviewed 28 out of 28 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
skill/migrate-clickable-box/SKILL.md |
Adds migration guidance for fullWidth and stretch-layout edge cases. |
shared/common-adapters/box.tsx |
Widens ClickableBox3 onClick callback type. |
shared/metro.config.js |
Anchors Metro block list regexes to the shared root. |
shared/teams/main/index.tsx |
Migrates team header controls to ClickableBox3. |
shared/teams/main/team-row.tsx |
Migrates team rows to ClickableBox3. |
shared/teams/role-picker.tsx |
Migrates role row wrapper. |
shared/teams/invite-by-contact/index.native.tsx |
Migrates mobile role picker box. |
shared/teams/common/channels-widget.tsx |
Migrates mobile channel input wrapper. |
shared/teams/common/use-autocompleter.tsx |
Migrates autocomplete options. |
shared/teams/add-members-wizard/confirm.tsx |
Migrates expanding divider row. |
shared/teams/emojis/add-emoji.tsx |
Migrates add-emoji icon action. |
shared/teams/emojis/common.tsx |
Migrates alias remove action. |
shared/teams/team/member/index.new.tsx |
Migrates expandable member row. |
shared/teams/team/member/add-to-channels.tsx |
Migrates mobile channel row. |
shared/teams/team/settings-tab/channel-popup.tsx |
Migrates channel popup rows. |
shared/teams/team/settings-tab/retention/index.tsx |
Migrates retention dropdown trigger. |
shared/team-building/contacts.tsx |
Migrates import contacts button. |
shared/team-building/user-bubble.tsx |
Migrates remove bubble action. |
shared/team-building/service-tab-bar.tsx |
Migrates service tab actions and more-networks button. |
shared/team-building/search-result/common-result.tsx |
Migrates search result row wrapper. |
shared/team-building/search-result/user-result.tsx |
Migrates add/remove action button. |
shared/team-building/search-result/people-result.tsx |
Migrates people result dropdown trigger. |
shared/profile/user/actions/index.tsx |
Adjusts profile actions dropdown sizing. |
shared/fs/browser/destination-picker.tsx |
Migrates destination picker action rows. |
shared/fs/common/path-item-action/header.tsx |
Migrates path action header wrapper. |
shared/fs/common/sfmi-popup.tsx |
Migrates popup propagation wrapper. |
shared/fs/top-bar/sort.tsx |
Migrates FS sort trigger. |
plans/clickablebox3.md |
Marks migration plan sections complete. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
* migrate shared/chat/ ClickableBox/CB2 → CB3
* migrate shared/common-adapters/ ClickableBox/CB2 → CB3
* complete ClickableBox3 migration: remove legacy CB1/CB2 exports
* WIP
* fixes
* Fix info panel tabs: natural width, centered text, divider spans full tab width
* WIP
* fix prove-your dialog items to be full width
Without fullWidth={true}, ClickableBox3 gets alignSelf:center applied,
centering each provider row instead of spanning the modal width.
* fix CardListItem body text centering: add fullWidth to body Box2
Nested Box2 direction="vertical" without fullWidth gets box2_centered
(align-self:center) applied, horizontally centering it within its
column flex parent. Fixed across all CardListItem callers and in
list-item.tsx's body wrapper.
* remove ChoiceList/RichButton, replace usages with ListItem Card
* remove ClickableBox/ClickableBox2 and migration plan — all usages migrated to ClickableBox3
* mass clean (#29268)
* simplify-ui: git/ — remove redundant wrappers, dead styles/comments, normalize patterns
* simplify-ui: devices/ — deduplicate icon logic, extract constants, replace style props
* simplify-ui: wallets/ — rename Container, extract shared styles, remove redundant props
* simplify-ui: tracker/ — fix hover-opacity typo, dedup utilities, rename Container, replace flexShrink props
* simplify-ui: settings/ — remove redundant wrappers, move styles to props, clean dead code
* simplify-ui: crypto/ — inline IIFEs, merge imports, clean up style props and names
* simplify-ui: teams/ — merge styles, fix functions-as-values, extract string constants, remove wrappers
* simplify-ui: signup/ — extract shared input width, fix prop shorthands, remove dead code
* simplify-ui: people/ — remove identity maps, dead code, inline wrappers, move style props
* simplify-ui: profile/ — remove dead code, dedup styles, replace Kb shims, noShrink props
* address PR feedback: safe nav in async callback, fix avatar overlay positioning, restore .tsx extension
* simplify-ui: full codebase pass — rename Containers, remove dead code, move style props
Ran simplify-ui-section skill across all UI directories via parallel subagents:
chat/, common-adapters/, fs/, login/, provision/, team-building/, unlock-folders/,
menubar/, pinentry/, incoming-share/, deeplinks/, router-v2/, and revisits of
profile/, people/, signup/, crypto/, teams/, settings/, tracker/, wallets/,
devices/, git/.
* fix back button hover area: remove inline-block and size(14) from iconContainer
The 14×14px fixed size caused the hover highlight to appear only in the
upper-left corner while the icon extended beyond it. The container now
sizes naturally around the icon with padding defining the hit area.
* fix Checkbox centering: add alignSelf=flex-start to ClickableBox3
* WIP
* fix iOS e2e: restore testID on mobile crypto nav rows
The RichButton→ListItem migration dropped testID; wrap ListItem in Box2 to carry it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.