Do not allow voting if user is not in conv where the poll is - #356
Merged
Conversation
michalz-zoom
force-pushed
the
michal/check-if-voter-is-in-conv
branch
3 times, most recently
from
September 1, 2026 19:17
11bbc51 to
49db19d
Compare
michalz-zoom
force-pushed
the
michal/check-if-voter-is-in-conv
branch
from
September 1, 2026 19:19
49db19d to
3a57be8
Compare
songgao-zoom
approved these changes
Sep 1, 2026
Comment on lines
+177
to
+179
| members.Owners, members.Admins, members.Writers, members.Readers, | ||
| members.Bots, members.RestrictedBots, | ||
| } |
There was a problem hiding this comment.
as discussed on chat maybe we could leave out the restricted bot here
Suggested change
| members.Owners, members.Admins, members.Writers, members.Readers, | |
| members.Bots, members.RestrictedBots, | |
| } | |
| members.Owners, members.Admins, members.Writers, | |
| members.Readers, members.Bots, | |
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Needed a fix in keybase/go-keybase-chat-bot#97