sil_tchad_qwerty#3619
Conversation
we add property: vertical-align: baseline in the Td.css
|
Thank you for your pull request. You'll see a "build failed" message until the Keyman team has reviewed the pull request and manually initiated the build process. Every change committed to this branch will become part of this pull request. When you have finished submitting files and are ready for the Keyman team to review this pull request, please post a "Ready for review" comment. |
|
Hi @roger-nadoumngar It looks like you added that file to the root of this folder Any time you make a change to a file that is part of a keyboard package you need to bump the keyboard version as well. Since this is a tiny change, you can bump the version by one increment. I think we are currently at 5.3.3, so you could make it 5.3.4. You'll need to change the version in the HISTORY.md and in the .kmn file. You should discuss with your team when would be an appropriate time to switch to using the new Charis font (which doesn't have SIL in the name anymore). If you wanted to do that, the link in your .css would be: Hope this is all clear. |
We added the line: text align. in the Td.css file for displaying PHP on the web.
We added the line: text align. in the Td.css file for displaying PHP on the web.
We added the line: text align. in the Td.css file for displaying PHP on the web.
addition of the line: text aligned for PHP display and change the version to5.3.4
Delete file in the wrong location (root of keyboards).
|
I'm sorry, but the version in the .kmn needs to be bumped, not just HISTORY.md. |
Bump version
LornaSIL
left a comment
There was a problem hiding this comment.
I was able to update the version in the .kmn so I can approve it. Make sure that version number gets bumped when you make changes to files that are included in the keyboard package.
we add property: vertical-align: baseline in the Td.css