Skip to content

sil_tchad_qwerty#3619

Merged
LornaSIL merged 10 commits into
keymanapp:masterfrom
roger-nadoumngar:sil_tchad_qwerty
Jul 30, 2025
Merged

sil_tchad_qwerty#3619
LornaSIL merged 10 commits into
keymanapp:masterfrom
roger-nadoumngar:sil_tchad_qwerty

Conversation

@roger-nadoumngar
Copy link
Copy Markdown
Contributor

we add property: vertical-align: baseline in the Td.css

we add property: vertical-align: baseline in the Td.css
@keyman-server
Copy link
Copy Markdown
Collaborator

Thank you for your pull request. You'll see a "build failed" message until the Keyman team has reviewed the pull request and manually initiated the build process.

Every change committed to this branch will become part of this pull request. When you have finished submitting files and are ready for the Keyman team to review this pull request, please post a "Ready for review" comment.

@LornaSIL
Copy link
Copy Markdown
Contributor

Hi @roger-nadoumngar It looks like you added that file to the root of this folder https://github.com/keymanapp/keyboards. It needs moving from there. It actually needs to be committed into the keyboard folder in the welcome folder where the existing one is. And you probably need to add it to the help folder as well since it's in both locations. If you add it to the welcome folder, that will be added to the keyboard package.

Any time you make a change to a file that is part of a keyboard package you need to bump the keyboard version as well. Since this is a tiny change, you can bump the version by one increment. I think we are currently at 5.3.3, so you could make it 5.3.4. You'll need to change the version in the HISTORY.md and in the .kmn file.

You should discuss with your team when would be an appropriate time to switch to using the new Charis font (which doesn't have SIL in the name anymore). If you wanted to do that, the link in your .css would be:
https://fonts.languagetechnology.org/fonts/sil/charis/web/Charis-Regular.woff2 and
https://fonts.languagetechnology.org/fonts/sil/charis/web/Charis-Regular.woff

Hope this is all clear.

roger-nadoumngar and others added 6 commits July 29, 2025 10:10
We added the line: text align. in the Td.css file for displaying PHP on the web.
We added the line: text align. in the Td.css file for displaying PHP on the web.
We added the line: text align. in the Td.css file for displaying PHP on the web.
 addition of the line: text aligned for PHP display and change the version to5.3.4
Delete file in the wrong location (root of keyboards).
@LornaSIL
Copy link
Copy Markdown
Contributor

I'm sorry, but the version in the .kmn needs to be bumped, not just HISTORY.md.

Copy link
Copy Markdown
Contributor

@LornaSIL LornaSIL left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was able to update the version in the .kmn so I can approve it. Make sure that version number gets bumped when you make changes to files that are included in the keyboard package.

@LornaSIL LornaSIL merged commit 38aa6d8 into keymanapp:master Jul 30, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants