[vietnam] update#3635
Merged
Merged
Conversation
ready for reviewing
Collaborator
|
Thank you for your pull request. You'll see a "build failed" message until the Keyman team has reviewed the pull request and manually initiated the build process. Every change committed to this branch will become part of this pull request. When you have finished submitting files and are ready for the Keyman team to review this pull request, please post a "Ready for review" comment. |
Contributor
|
You have three rules that have an uneven number of stores. These should be resolved: In the first one it is |
Contributor
Author
|
I fixed those issues.
Sent with [Proton Mail](https://proton.me/mail/home) secure email.
…On Monday, 21 July 2025 at 5:59 PM, Lorna Evans ***@***.***> wrote:
LornaSIL left a comment [(keymanapp/keyboards#3635)](#3635 (comment))
You have three rules that have an uneven number of stores. These should be resolved:
any(c) any(h) any(consonants) any(s_all_letters) any(s_all_letters) any(s_all_letters) any(s_no_d_letters) + any(all_letters) > context index(punctuationc, 8)
any(ie_end) any(i) any(o) any(end_consonants) + any(two_o) > index(ie_consonants, 1) index(i, 2) index(oo, 3) index(end_consonants, 4)
any(ae) any(two_o) + any(two_o) > index(ae, 1) index(o, 2) index(o, 3)
In the first one it is punctuationc that has way more letters than all_letters
I didn't check the other rules. You can check the messages window, but the first rule is around line 1117.
—
Reply to this email directly, [view it on GitHub](#3635 (comment)), or [unsubscribe](https://github.com/notifications/unsubscribe-auth/BCAJHRRK44WEVMGMNWH7WED3JUMANAVCNFSM6AAAAACB35DXK6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZTAOJXGYYDIOBYGM).
You are receiving this because you authored the thread.Message ID: ***@***.***>
|
Contributor
Author
|
Can you merge the request?
Sent from [Proton Mail](https://proton.me/mail/home) for iOS
…On Mon, Jul 21, 2025 at 19:29, Lorna Evans ***@***.***(mailto:On Mon, Jul 21, 2025 at 19:29, Lorna Evans <<a href=)> wrote:
@LornaSIL approved this pull request.
Thanks!
—
Reply to this email directly, [view it on GitHub](#3635 (review)), or [unsubscribe](https://github.com/notifications/unsubscribe-auth/BCAJHRRNNNI5WRYHFBPXWKD3JUWPLAVCNFSM6AAAAACB35DXK6VHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZTAMZZGI2DOMBVGQ).
You are receiving this because you authored the thread.Message ID: ***@***.***>
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ready for reviewing