Skip to content

[phonetic_farsi] Update copyright and contact details#3637

Merged
LornaSIL merged 12 commits into
keymanapp:masterfrom
kojamori:master
Jul 23, 2025
Merged

[phonetic_farsi] Update copyright and contact details#3637
LornaSIL merged 12 commits into
keymanapp:masterfrom
kojamori:master

Conversation

@kojamori
Copy link
Copy Markdown
Contributor

No description provided.

@keyman-server
Copy link
Copy Markdown
Collaborator

Thank you for your pull request. You'll see a "build failed" message until the Keyman team has reviewed the pull request and manually initiated the build process.

Every change committed to this branch will become part of this pull request. When you have finished submitting files and are ready for the Keyman team to review this pull request, please post a "Ready for review" comment.

@LornaSIL
Copy link
Copy Markdown
Contributor

Normally I would question changing the license holder, but since you are the one who made the original commit, this is fine.

However, any time a change is made to a file that is distributed within a keyboard package, the version must be bumped.

In this case you should bump the version in the .kmn to something like 2.0.1 and add a line to HISTORY.md with the version and date and explain what changed. I don't know why HISTORY.md doesn't have an entry for 2.0. If you remember what changed, it would be good to add an entry for that version as well.

@kojamori
Copy link
Copy Markdown
Contributor Author

Hi, I've bumped the version in both the .kmn and .kp
image
Also, the entry for version 2.0 in HISTORY.md is present from what I can see, I have no issue viewing it on my end.

LornaSIL added 2 commits July 23, 2025 09:00
The version is the .kpj is related to a Keyman version related for the format of the .kpj file, not the keyboard version, so I reverted that.
Copy link
Copy Markdown
Contributor

@LornaSIL LornaSIL left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Thanks.

@LornaSIL LornaSIL merged commit 7be85ab into keymanapp:master Jul 23, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants