kirikirʔi:s (Wichita)#3688
Conversation
|
Thank you for your pull request. You'll see a "build failed" message until the Keyman team has reviewed the pull request and manually initiated the build process. Every change committed to this branch will become part of this pull request. When you have finished submitting files and are ready for the Keyman team to review this pull request, please post a "Ready for review" comment. |
|
I haven't looked in detail, but this submission looks very good. One thing I noticed is that the welcome.htm file is not mentioned in the "Welcome file" field (Package Details screen). That's not absolutely necessary for the "experimental" section of the repository, where we don't require user documentation. Eventually you'll need a "help" folder (under the "source" folder) that contains a PHP help file named |
|
Thanks @DavidLRowe |
|
@michael-wynne-wsu this recent comment was made by someone who is not part of the Keyman team. Please ignore. |
Update copyright years.
Tablet and Phone matched. Remove Tablet to ease maintenance.
Add welcome.htm to installer.
|
I've made a few changes so we can go ahead and approve this. You can always update the documentation later. Since your keyboard is in experimental, the lack of documentation is acceptable. |
LornaSIL
left a comment
There was a problem hiding this comment.
@michael-wynne-wsu Approving as is. Feel free to update it with improved documentation.
This keyboard is currently undergoing final review by Wichita community members. I don't anticipate any/many changes, but wanted to test the submission process in the meantime.
I am working on this keyboard on behalf of Translation Commons