Skip to content

kirikirʔi:s (Wichita)#3688

Merged
LornaSIL merged 5 commits into
keymanapp:masterfrom
michael-wynne-wsu:master
Oct 28, 2025
Merged

kirikirʔi:s (Wichita)#3688
LornaSIL merged 5 commits into
keymanapp:masterfrom
michael-wynne-wsu:master

Conversation

@michael-wynne-wsu
Copy link
Copy Markdown
Contributor

This keyboard is currently undergoing final review by Wichita community members. I don't anticipate any/many changes, but wanted to test the submission process in the meantime.

I am working on this keyboard on behalf of Translation Commons

@keyman-server
Copy link
Copy Markdown
Collaborator

Thank you for your pull request. You'll see a "build failed" message until the Keyman team has reviewed the pull request and manually initiated the build process.

Every change committed to this branch will become part of this pull request. When you have finished submitting files and are ready for the Keyman team to review this pull request, please post a "Ready for review" comment.

@DavidLRowe
Copy link
Copy Markdown
Contributor

I haven't looked in detail, but this submission looks very good. One thing I noticed is that the welcome.htm file is not mentioned in the "Welcome file" field (Package Details screen). That's not absolutely necessary for the "experimental" section of the repository, where we don't require user documentation. Eventually you'll need a "help" folder (under the "source" folder) that contains a PHP help file named kirikiris.php. (The PHP help provides the online help; the welcome.htm has the help that is packaged with the keyboard. Eventually we hope to unify these, but currently we have this duplication. Often people develop the welcome.htm, then copy portions of it into the PHP file.)

@michael-wynne-wsu
Copy link
Copy Markdown
Contributor Author

Thanks @DavidLRowe
I will go over the documentation for the welcome files and help folders etc more thoroughly and get that information closer to final. But if anyone does review it more in the meantime I would appreciate another recommended or required edits!

@LornaSIL
Copy link
Copy Markdown
Contributor

@michael-wynne-wsu this recent comment was made by someone who is not part of the Keyman team. Please ignore.

Update copyright years.
Tablet and Phone matched. Remove Tablet to ease maintenance.
Add welcome.htm to installer.
@LornaSIL
Copy link
Copy Markdown
Contributor

I've made a few changes so we can go ahead and approve this. You can always update the documentation later. Since your keyboard is in experimental, the lack of documentation is acceptable.

Copy link
Copy Markdown
Contributor

@LornaSIL LornaSIL left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@michael-wynne-wsu Approving as is. Feel free to update it with improved documentation.

@LornaSIL LornaSIL merged commit bfa2038 into keymanapp:master Oct 28, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants