GeezWord Tigrinya v18.0

[dyacob]

This is the GeezWord Tigrinya Keyboard v18.0 by GeezSoft. This is the initial public release of the keyboard package and includes both desktop and mobile layouts.

[keyman-server]

Thank you for your pull request. You'll see a "build failed" message until the Keyman team has reviewed the pull request and manually initiated the build process.

Every change committed to this branch will become part of this pull request. When you have finished submitting files and are ready for the Keyman team to review this pull request, please post a "Ready for review" comment.

[LornaSIL]

Is the keyboard ready for review? Before a review I see 3 things:

• delete desktop.ini
• the gff_amharic/HISTORY.md file was modified unintentionally I assume.
• We have preferred .htm extensions instead of html. I can't remember why, but can you change welcome.html to welcome.htm?

[dyacob]

Hi @LornaSIL , the 3 issues should all be addressed now and the submission is ready for review. Thanks!

[LornaSIL]

• The LICENSE.md needs the copyright date of 20232-2025 to 2023-2025.
• Can you remove the copyright dates in the README.md?
• There are other locations with this same issue (.kmn, .kps, welcome.htm, and php file). It would be easiest not to include the dates unless you feel strongly because no one wants to remember to update it everywhere each year it changes. The LICENSE.md is considered authoritative.
• The .php header needs all the style information within the php header. You can see how it's done in this file: https://github.com/keymanapp/keyboards/blob/master/release/t/tibetan_direct_input/source/help/tibetan_direct_input.php
• I prefer not to include the version anywhere except in the .kmn so it would be good to remove it from the readme.htm .
• In the .kps the welcome file referenced should be changed to welcome.htm instead of welcome.html.

[dyacob]

Thanks @LornaSIL , excellent catches and recommendations as usual 😃 I've checked in adjustments for each. Thanks!

[DavidLRowe]

Is "All rights reserved" in the copyright statement compatible with MIT license?

[dyacob]

Good point @DavidLRowe . The legal side of things has me out of my depth to even contemplate. I did a quick search and found the question has come up for other projects. This post raises the question and the accepted answer is "It's correct but unnecessary. It's there for clarity.", with some elaboration on why : https://opensource.stackexchange.com/questions/2121/mit-license-and-all-rights-reserved

But we can remove it nonetheless for consistency with other keyman keyboards, LMK.

[LornaSIL]

The "All Rights Reserved" should be removed. @mcdurdin says "It can't be in the LICENSE.md, because our license check code will reject it as a modification of the license." So, go ahead and remove it from all copyright statements. Otherwise, the keyboard builds.

[dyacob]

Fixed now. Thanks for the investigation and explanation. 😃

[mcdurdin]

@mcdurdin says "It can't be in the LICENSE.md, because our license check code will reject it as a modification of the license."

Turns out it would have been okay because it was in the copyright line ... but still, it'll be confusing if we ever extract copyright holder from the copyright line automatically in the future...

[LornaSIL]

LGTM