Skip to content

[geezword_tigrinya] Fix help CSS indentation level#3764

Merged
darcywong00 merged 1 commit into
keymanapp:masterfrom
darcywong00:geezword_tigrinya/help
Oct 29, 2025
Merged

[geezword_tigrinya] Fix help CSS indentation level#3764
darcywong00 merged 1 commit into
keymanapp:masterfrom
darcywong00:geezword_tigrinya/help

Conversation

@darcywong00
Copy link
Copy Markdown
Contributor

Fixes CSS indentation of the geezword_tigrinya help file which blocked help deployment on keymanapp/help.keyman.com#2312 and keymanapp/help.keyman.com#2313

PHP Parse error: Invalid body indentation level (expecting an indentation level of at least 2) in ./keyboard/geezword_tigrinya/18.0/geezword_tigrinya.php on line 6

@darcywong00 darcywong00 enabled auto-merge October 28, 2025 23:43
@darcywong00 darcywong00 merged commit 209ba09 into keymanapp:master Oct 29, 2025
2 checks passed
@DavidLRowe
Copy link
Copy Markdown
Contributor

@dyacob I learned something new today (or maybe relearned something I'd forgotten)!

@darcywong00 darcywong00 deleted the geezword_tigrinya/help branch October 29, 2025 01:20
@dyacob
Copy link
Copy Markdown
Contributor

dyacob commented Oct 29, 2025

Oh? Indentation matters?? I thought that was just for Python. @DavidLRowe new to me also, I don't think I ever knew. Thanks guys for catching and fixing this!

@mcdurdin
Copy link
Copy Markdown
Member

For reference, it's because the END closing marker is indented -- and behaviour changed in recent versions of PHP.

https://stackoverflow.com/questions/55523412/invalid-body-indentation-level-expecting-an-indentation-level-of-at-least-4

@LornaSIL
Copy link
Copy Markdown
Contributor

There's also an issue of mixing spaces and tabs for indentation. I don't think this one had that problem, but I need to remember to check that also!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants