Skip to content

Engram#3767

Merged
DavidLRowe merged 11 commits into
keymanapp:masterfrom
binarybottle:engram
Oct 31, 2025
Merged

Engram#3767
DavidLRowe merged 11 commits into
keymanapp:masterfrom
binarybottle:engram

Conversation

@binarybottle
Copy link
Copy Markdown
Contributor

I am submitting this PR to deprecate the original engram layout and include it with the newer engram_en layout within the same release/engram/ folder.

@binarybottle
Copy link
Copy Markdown
Contributor Author

Ready to review

@keyman-server
Copy link
Copy Markdown
Collaborator

Thank you for your pull request. You'll see a "build failed" message until the Keyman team has reviewed the pull request and manually initiated the build process.

Every change committed to this branch will become part of this pull request. When you have finished submitting files and are ready for the Keyman team to review this pull request, please post a "Ready for review" comment.

@mcdurdin
Copy link
Copy Markdown
Member

Can you please add a file release/engram/engram/DEPRECATED.md with the following content:

This keyboard has been deprecated and replaced by release/engram/engram_en.

It's purely informational but helps other people who look at the repo in the future.

(I will leave full review to @DavidLRowe or @LornaSIL!)

@binarybottle
Copy link
Copy Markdown
Contributor Author

Can you please add a file release/engram/engram/DEPRECATED.md with the following content:

This keyboard has been deprecated and replaced by release/engram/engram_en.

It's purely informational but helps other people who look at the repo in the future.

(I will leave full review to @DavidLRowe or @LornaSIL!)

Thank you very much, @mcdurdin ! I have added the file.

@binarybottle
Copy link
Copy Markdown
Contributor Author

Ready for review.

Copy link
Copy Markdown
Contributor

@DavidLRowe DavidLRowe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I had to adjust the .kpj files (change version number from 1.0 to 2.0 to reflect the new format of the project file). The default for the "build" folder changed between those two versions, so the packaging failed. (I also corrected the engram.php filename and used 2025 in the copyright for engram_en/LICENSE.md.

You'll want to pick up the changed files. This "howto" article may be useful: https://help.keyman.com/knowledge-base/?id=106

@DavidLRowe DavidLRowe merged commit bd11d2d into keymanapp:master Oct 31, 2025
2 checks passed
@binarybottle
Copy link
Copy Markdown
Contributor Author

I had to adjust the .kpj files (change version number from 1.0 to 2.0 to reflect the new format of the project file). The default for the "build" folder changed between those two versions, so the packaging failed. (I also corrected the engram.php filename and used 2025 in the copyright for engram_en/LICENSE.md.

You'll want to pick up the changed files. This "howto" article may be useful: https://help.keyman.com/knowledge-base/?id=106

THANK YOU, @DavidLRowe, and Happy Halloween!

@binarybottle
Copy link
Copy Markdown
Contributor Author

Thank you, @DavidLRowe, @LornaSIL, and @mcdurdin!

After launching the layout on Keyman, I submitted an article to an ergonomics journal and celebrated by dressing this year as The Engram for Halloween!

@binarybottle binarybottle deleted the engram branch November 1, 2025 05:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants