Engram#3767
Conversation
|
Ready to review |
|
Thank you for your pull request. You'll see a "build failed" message until the Keyman team has reviewed the pull request and manually initiated the build process. Every change committed to this branch will become part of this pull request. When you have finished submitting files and are ready for the Keyman team to review this pull request, please post a "Ready for review" comment. |
|
Can you please add a file release/engram/engram/DEPRECATED.md with the following content: This keyboard has been deprecated and replaced by release/engram/engram_en.It's purely informational but helps other people who look at the repo in the future. (I will leave full review to @DavidLRowe or @LornaSIL!) |
Thank you very much, @mcdurdin ! I have added the file. |
|
Ready for review. |
DavidLRowe
left a comment
There was a problem hiding this comment.
I had to adjust the .kpj files (change version number from 1.0 to 2.0 to reflect the new format of the project file). The default for the "build" folder changed between those two versions, so the packaging failed. (I also corrected the engram.php filename and used 2025 in the copyright for engram_en/LICENSE.md.
You'll want to pick up the changed files. This "howto" article may be useful: https://help.keyman.com/knowledge-base/?id=106
THANK YOU, @DavidLRowe, and Happy Halloween! |
|
Thank you, @DavidLRowe, @LornaSIL, and @mcdurdin! After launching the layout on Keyman, I submitted an article to an ergonomics journal and celebrated by dressing this year as The Engram for Halloween! |
I am submitting this PR to deprecate the original engram layout and include it with the newer engram_en layout within the same release/engram/ folder.