[runeboard] Version 4#3768
Conversation
|
Thank you for your pull request. You'll see a "build failed" message until the Keyman team has reviewed the pull request and manually initiated the build process. Every change committed to this branch will become part of this pull request. When you have finished submitting files and are ready for the Keyman team to review this pull request, please post a "Ready for review" comment. |
|
It looks good. I do have one suggestion. We like to use The font you added is v2.200 and the one we have in Since you have the whole Keyman repo cloned, I would recommend that you add the font you have in the runeboard folder to That would help us keep the most up-to-date font in release. If that's too confusing, I can approve it, but then I'll want to update the font in |
Version 2.2
Update font location (3 lines edited)
Moved to ..\..\..\..\release\shared\fonts\catrinity\Catrinity.otf
|
Thanks. Were those changes made correctly? |
LornaSIL
left a comment
There was a problem hiding this comment.
I think it was done correctly. Thank you so much.
It would also be wise to update these other keyboards using the font. Do you want to update those keyboards, or should I?
carian
elymaic
tsakonian
old_english
|
Would you mind updating the other keyboards please? That way, I can check how you've done things later if I run into any future problems with confidence that I'm relying upon the work of someone much more experienced in this field. |
|
Also, I've noticed what I can only call a display error in the mobile version which I'm not quite sure how to solve. The spacebar has several longpress options but, because they display on a key the same width as the spacebar itself, only the first 3 are visible on my mobile. (This might exclusively be a problem of small devices, or an Android issue.) Q: Is there a way to change the width of a longpress option without changing the width of the underlying key? If not, I'm thinking it would be best to move the last 5 of those longpress options to the ZWJ key (left of the spacebar). |
|
I just noticed the Runeboard's latest help page appears to be displaying «double angle quotation marks» and ⟪double angle brackets⟫ around the wrong way. From what I can tell, this is because I forgot to save the kvks file before uploading it. I'll incorporate the fix for that into version 4.1 with whatever the longpress fix we work out. The other changes I made to kvks file are mostly organisational (e.g. alphabetising) however I've found a few other mistakes too, which I'll correct. Finally, I've added 1 key to the SRA layer for desktop in version 4.1. It's not really essential but it cuts out the ZWJs when typing "᛫᛫᛫". |
The overly-wide keys in the longpress menu for the spacebar have been documented as an issue in keymanapp/keyman#7863. We do aim to address that in the future, but do not currently have a date.
There is no way to specify the width of a longpress key at this stage. |
Okay, thanks. In that case, I'll reposition the longpress keys. |
Mostly key repositionings. If there are any problems, please just say.