Skip to content

[shanghai_jamo] updating#3799

Merged
LornaSIL merged 7 commits into
keymanapp:masterfrom
Cathaylaboratory:master
Dec 1, 2025
Merged

[shanghai_jamo] updating#3799
LornaSIL merged 7 commits into
keymanapp:masterfrom
Cathaylaboratory:master

Conversation

@Cathaylaboratory
Copy link
Copy Markdown
Contributor

ready for reviewing

@keyman-server
Copy link
Copy Markdown
Collaborator

Thank you for your pull request. You'll see a "build failed" message until the Keyman team has reviewed the pull request and manually initiated the build process.

Every change committed to this branch will become part of this pull request. When you have finished submitting files and are ready for the Keyman team to review this pull request, please post a "Ready for review" comment.

@DavidLRowe
Copy link
Copy Markdown
Contributor

Thanks for your submission.

You'll need to update the .kmn file to make the same version number change you made in HISTORY.md

@Cathaylaboratory
Copy link
Copy Markdown
Contributor Author

Cathaylaboratory commented Nov 30, 2025 via email

@DavidLRowe
Copy link
Copy Markdown
Contributor

In the experimental/s/shanghai_jamo/source/help/ folder,

  • wuvowles.png is misspelled
  • wutones.png is not present

@LornaSIL LornaSIL changed the title shanghai jamo updating [shanghai_jamo] updating Dec 1, 2025
Copy link
Copy Markdown
Contributor

@LornaSIL LornaSIL left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. Changes look good.

@LornaSIL LornaSIL merged commit b5598bb into keymanapp:master Dec 1, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants