[shanghai_jamo] updating#3799
Merged
Merged
Conversation
Collaborator
|
Thank you for your pull request. You'll see a "build failed" message until the Keyman team has reviewed the pull request and manually initiated the build process. Every change committed to this branch will become part of this pull request. When you have finished submitting files and are ready for the Keyman team to review this pull request, please post a "Ready for review" comment. |
Contributor
|
Thanks for your submission. You'll need to update the .kmn file to make the same version number change you made in HISTORY.md |
Contributor
Author
|
I made the change
Sent with [Proton Mail](https://proton.me/mail/home) secure email.
…On Tuesday, 25 November 2025 at 4:40 PM, DavidLRowe ***@***.***> wrote:
DavidLRowe left a comment [(keymanapp/keyboards#3799)](#3799 (comment))
Thanks for your submission.
You'll need to update the .kmn file to make the same version number change you made in HISTORY.md
—
Reply to this email directly, [view it on GitHub](#3799 (comment)), or [unsubscribe](https://github.com/notifications/unsubscribe-auth/BCAJHRXZ37GI2WBK5PDJJ7336SA67AVCNFSM6AAAAACNC23BVSVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZTKNZWGU2TGOBYGM).
You are receiving this because you authored the thread.Message ID: ***@***.***>
|
Contributor
|
In the experimental/s/shanghai_jamo/source/help/ folder,
|
LornaSIL
approved these changes
Dec 1, 2025
Contributor
LornaSIL
left a comment
There was a problem hiding this comment.
Thanks. Changes look good.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ready for reviewing