Skip to content

[slp1_deva] update consonants store and output of key q#3804

Merged
darcywong00 merged 3 commits into
keymanapp:masterfrom
Meng-Heng:slp1_deva-change-consonants
Nov 28, 2025
Merged

[slp1_deva] update consonants store and output of key q#3804
darcywong00 merged 3 commits into
keymanapp:masterfrom
Meng-Heng:slp1_deva-change-consonants

Conversation

@Meng-Heng
Copy link
Copy Markdown
Contributor

@Meng-Heng Meng-Heng commented Nov 28, 2025

follow #3800.

A request from our community:

Changed line 13
store(consonants) U+0915 U+0916 U+0917 U+0918 U+0919 U+091A U+091B U+091C U+091D U+091E U+091F U+0920 U+0922 U+0923 U+0933 U+0934 U+0924 U+0925 U+0926 U+0927 U+0928 U+092A U+092B U+092C U+092D U+092E U+092F U+0930 U+0932 U+0935 U+0936 U+0937 U+0938 U+0939

to

store(consonants) U+0915 U+0916 U+0917 U+0918 U+0919 U+091A U+091B U+091C U+091D U+091E U+091F U+0920 U+0921 U+0922 U+0923 U+0924 U+0925 U+0926 U+0927 U+0928 U+092A U+092B U+092C U+092D U+092E U+092F U+0930 U+0932 U+0933 U+0935 U+0936 U+0937 U+0938 U+0939

(in which I deleted U+0934 but added U+0921)

and changed line 64

[SHIFT K_Q] > U+0926 U+094D
to

[SHIFT K_Q] > U+0922 U+094D

The revision I just sent you a few minutes ago remains to be made.
Please do go ahead and make it.

Test-bot: skip

This PR is ready for reviews.

@keyman-server
Copy link
Copy Markdown
Collaborator

Thank you for your pull request. You'll see a "build failed" message until the Keyman team has reviewed the pull request and manually initiated the build process.

Every change committed to this branch will become part of this pull request. When you have finished submitting files and are ready for the Keyman team to review this pull request, please post a "Ready for review" comment.

<Name>slp1_deva</Name>
<ID>slp1_deva</ID>
<Version>1.0.2</Version>
<Version>1.0.3</Version>
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please also update the keyboard version in slp1_deva.kmn to 1.0.3

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you

+ [SHIFT K_L] > U+0933 U+094D
+ [SHIFT K_R] > U+0923 U+094D
+ [SHIFT K_Q] > U+0926 U+094D
+ [SHIFT K_Q] > U+0922 U+094D
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should also update the .kvks with this change

Comment thread release/s/slp1_deva/source/slp1_deva.kmn Outdated
Copy link
Copy Markdown
Contributor

@darcywong00 darcywong00 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@darcywong00 darcywong00 merged commit 1aab9e5 into keymanapp:master Nov 28, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants