chore(common): replace codecvt in module u16 🐸 #12107
Merged
SabineSIL merged 5 commits intorefactor/core/make-utfcodec-commonfrom Aug 13, 2024
Merged
chore(common): replace codecvt in module u16 🐸 #12107SabineSIL merged 5 commits intorefactor/core/make-utfcodec-commonfrom
SabineSIL merged 5 commits intorefactor/core/make-utfcodec-commonfrom
Conversation
User Test ResultsTest specification and instructions User tests are not required Test Artifacts
|
github-actions
bot
added
developer/
developer/compilers/
common/
and removed
common/
labels
SabineSIL
changed the title
Contributor
Author
|
In kmx_u16.cpp/ u16tof(): use strtof() inside of u16tof() since u16tof() gave interesting results (e.g. rounds where it should not) |
SabineSIL
force-pushed
the
chore/common/remove_codecvt
branch
from
a0ae35a to
a3a7bd3
Compare
SabineSIL
changed the base branch from
master
to
refactor/core/make-utfcodec-common
mcdurdin
reviewed
Aug 13, 2024
| /* Record a system store for the line number of the begin statement */ | ||
| //wcscpy(tstr, DEBUGSTORE_MATCH); | ||
| u16sprintf(tstr, _countof(tstr), L"%ls%d ", u16fmt(DEBUGSTORE_MATCH).c_str(), (int) fk->currentGroup); | ||
| u16sprintf(tstr, _countof(tstr), L"%ls%d ", wstring_from_u16string(DEBUGSTORE_MATCH).c_str(), (int) fk->currentGroup); |
Member
There was a problem hiding this comment.
Suggested change
| u16sprintf(tstr, _countof(tstr), L"%ls%d ", wstring_from_u16string(DEBUGSTORE_MATCH).c_str(), (int) fk->currentGroup); | |
| u16sprintf(tstr, _countof(tstr), L"%ls%d ", DEBUGSTORE_MATCH_L, (int) fk->currentGroup); |
and then define:
#define DEBUGSTORE_MATCH_U u"M"
#define DEBUGSTORE_MATCH_L L"M"
….._L , DEBUGSTORE_..._U
ermshiperete
approved these changes
Aug 13, 2024
8 tasks
8 tasks
mcdurdin
added a commit
that referenced
this pull request
Nov 6, 2024
mcdurdin
added a commit
that referenced
this pull request
Nov 7, 2024
…on-debug-store fix(developer): use 'N' for nomatch store debug strings (regression in #12107)
ermshiperete
added a commit
that referenced
this pull request
Jul 17, 2025
codecvt is deprecated in C++ 17. See also #12107. Test-bot: skip
ermshiperete
added a commit
that referenced
this pull request
Jul 18, 2025
codecvt is deprecated in C++ 17. See also #12107. Test-bot: skip
ermshiperete
added a commit
that referenced
this pull request
Jul 18, 2025
codecvt is deprecated in C++ 17. See also #12107.
cvosoft
pushed a commit
to cvosoft/keyman
that referenced
this pull request
Oct 23, 2025
codecvt is deprecated in C++ 17. See also keymanapp#12107. Test-bot: skip
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
std::codecvt will be deprecated by C++17.
We still use std::codecvt in module u16 in /developer/src/kmcmplib/src/
std::codecvt needs to be exchanged with "convert" from utfcodec.hpp
fixes #11922
@keymanapp-test-bot skip