refactor(developer): replace deprecated std::codecvt_utf8_utf16 🐾#14369
Merged
ermshiperete merged 2 commits intomasterfrom Jul 18, 2025
Merged
refactor(developer): replace deprecated std::codecvt_utf8_utf16 🐾#14369ermshiperete merged 2 commits intomasterfrom
ermshiperete merged 2 commits intomasterfrom
Conversation
User Test ResultsTest specification and instructions User tests are not required |
ermshiperete
changed the title
codecvt is deprecated in C++ 17. See also #12107. Test-bot: skip
ermshiperete
force-pushed
the
refactor/developer/codecvt
branch
from
d9843e0 to
6930fe9
Compare
Collaborator
|
Changes in this pull request will be available for download in Keyman version 19.0.85-alpha |
mcdurdin
reviewed
Jul 20, 2025
| return result.size() > 0 && result[0] == 0xFEFF; | ||
| } | ||
|
|
||
| bool isValidUtf8(KMX_BYTE* str, int sz) { |
Member
There was a problem hiding this comment.
This fairly complex function seems to be very lightly tested. Is it original code or copied from somewhere?
Contributor
Author
There was a problem hiding this comment.
ah, yes, unit tests would be good 😄 I copied it from somewhere and reviewed it carefully, but nevertheless it should have unit tests. Done in #14381.
ermshiperete
added a commit
that referenced
this pull request
Jul 21, 2025
Follow-up-of: #14369 Test-bot: skip
ermshiperete
added a commit
that referenced
this pull request
Jul 29, 2025
test(developer): add unit tests for `isValidUtf8` Follow-up-of: #14369
cvosoft
pushed a commit
to cvosoft/keyman
that referenced
this pull request
Oct 23, 2025
Follow-up-of: keymanapp#14369 Test-bot: skip
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
codecvt is deprecated in C++ 17. See also #12107.
Test-bot: skip