maint(common): consolidate write_download_info functions 🐉#14270
Merged
ermshiperete merged 1 commit intomasterfrom Jul 7, 2025
Merged
maint(common): consolidate write_download_info functions 🐉#14270ermshiperete merged 1 commit intomasterfrom
write_download_info functions 🐉#14270ermshiperete merged 1 commit intomasterfrom
Conversation
User Test ResultsTest specification and instructions User tests are not required |
github-actions
bot
added
web/
windows/
android/
developer/
ios/
mac/
linux/
common/
core/
ermshiperete
changed the title
write_download_info functionswrite_download_info functions 🐉
Member
|
We should run the builds for Android and iOS at least as these are touched by this change.
I am confusing Build-bot with build status check. Given I wrote these, and I am confused, this will probably be a problem for other devs too. I will consider improvements. Resolution: after changing the Build-bot commands in PR body, I triggered test builds for this PR on TeamCity. (This feels like it should happen automatically when Build-bot commands change in the PR body and/or comments; something for future improvement perhaps?) |
ermshiperete
force-pushed
the
refactoring/common/shellHelperFuncs
branch
from
5f86f42 to
38f43d8
Compare
Fixes: #14259 Build-bot: skip Test-bot: skip
ermshiperete
force-pushed
the
maint/common/14259_write_download_info
branch
from
09758ad to
a252025
Compare
Collaborator
|
Changes in this pull request will be available for download in Keyman version 19.0.79-alpha |
ermshiperete
added a commit
that referenced
this pull request
Jul 7, 2025
This fixes the release builds. Follow-up-of: #14270 Build-bot: skip Test-bot: skip # Keyman Conventional Commit suggestions: # # - Link to a Sentry issue with git trailer: # Fixes: _MODULE_-_ID_ # - Give credit to co-authors: # Co-authored-by: _Name_ <_email_> # - Use imperative, present tense ('attach' not 'attaches', 'attached' etc) # - Don't include a period at the end of the title # - Always include a blank line before trailers # - More: https://github.com/keymanapp/keyman/wiki/Pull-Request-and-Commit-workflow-notes
ermshiperete
added a commit
that referenced
this pull request
Jul 7, 2025
This fixes the release builds. Follow-up-of: #14270 Build-bot: skip Test-bot: skip
ermshiperete
added a commit
that referenced
this pull request
Jul 9, 2025
The .download_info files use the platform `win` instead of `windows`. This PR changes this, and also renames the `_verify_project` function to `_verify_platform` to better match what it's checking. Fixes Windows release builds. Follow-up-of: #14270
ermshiperete
added a commit
that referenced
this pull request
Jul 21, 2025
Mac had a separate `write-download_info.sh` script that duplicates what is done in the `write_download_info` function. Also remove the unused `dl_info_display_usage` function that is unused and seems to be related to the script we're deleting. Follow-up-of: #14270
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: #14259
Build-bot: skip
Build-bot: build android
Build-bot: build ios
Test-bot: skip