Skip to content

maint(windows): fix platform name for Windows 🩹#14321

Merged
ermshiperete merged 2 commits intomasterfrom
maint/windows/fixrelease
Jul 9, 2025
Merged

maint(windows): fix platform name for Windows 🩹#14321
ermshiperete merged 2 commits intomasterfrom
maint/windows/fixrelease

Conversation

@ermshiperete
Copy link
Copy Markdown
Contributor

@ermshiperete ermshiperete commented Jul 9, 2025 •
edited
Loading

The .download_info files use the platform win instead of windows. This PR changes this, and also renames the _verify_project function to _verify_platform to better match what it's checking. Fixes Windows release builds.

Follow-up-of: #14270
Test-bot: skip

@ermshiperete
maint(windows): fix platform name for Windows 🩹
479a0da 
The .download_info files use the platform `win` instead of `windows`.
This PR changes this, and also renames the `_verify_project` function
to `_verify_platform` to better match what it's checking. Fixes Windows
release builds.

Test-bot: skip
@github-project-automation github-project-automation bot moved this to Todo in Keyman Jul 9, 2025
@keymanapp-test-bot
Copy link
Copy Markdown

keymanapp-test-bot bot commented Jul 9, 2025 •
edited
Loading

User Test Results

Test specification and instructions

User tests are not required

Test Artifacts

@keymanapp-test-bot keymanapp-test-bot bot added this to the A19S7 milestone Jul 9, 2025
@github-actions github-actions bot added resources/ maint Maintenance work -- continuous integration, build scripts, infrastructure windows/ labels Jul 9, 2025
darcywong00
darcywong00 reviewed Jul 9, 2025
View reviewed changes
Base automatically changed from maint/android/fixrelease to master July 9, 2025 14:08
@ermshiperete @darcywong00
Update resources/shellHelperFunctions.sh
8f02063 
Co-authored-by: Darcy Wong <darcy_wong@sil.org>
@ermshiperete ermshiperete requested a review from darcywong00 July 9, 2025 14:09
@github-actions github-actions bot added windows/ and removed windows/ labels Jul 9, 2025
darcywong00
darcywong00 approved these changes Jul 9, 2025
View reviewed changes
Copy link
Copy Markdown
Contributor

@darcywong00 darcywong00 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

how was this working with "windows" before?

@ermshiperete
Copy link
Copy Markdown
Contributor Author

ermshiperete commented Jul 9, 2025

how was this working with "windows" before?

write_download_info in shellHelperFunctions.sh (which used windows) was outdated for the last several Keyman versions. It did get called, but we called a different implementation of write_download_info (which used win) again later in the build, so the file got overwritten.

@ermshiperete ermshiperete merged commit b7466f7 into master Jul 9, 2025
29 checks passed
@ermshiperete ermshiperete deleted the maint/windows/fixrelease branch July 9, 2025 16:34
@github-project-automation github-project-automation bot moved this from Todo to Done in Keyman Jul 9, 2025
@keyman-server
Copy link
Copy Markdown
Collaborator

keyman-server commented Jul 9, 2025

Changes in this pull request will be available for download in Keyman version 19.0.81-alpha

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@srl295 srl295 srl295 approved these changes

@darcywong00 darcywong00 darcywong00 approved these changes

@mcdurdin mcdurdin Awaiting requested review from mcdurdin

@rc-swag rc-swag Awaiting requested review from rc-swag

@jahorton jahorton Awaiting requested review from jahorton

Assignees

No one assigned

Labels

maint Maintenance work -- continuous integration, build scripts, infrastructure resources/ windows/

Projects

Keyman
Archived in project

Milestone

A19S7

Development

Successfully merging this pull request may close these issues.

4 participants

@ermshiperete @keyman-server @srl295 @darcywong00