Skip to content

test(developer): add unit tests for isValidUtf8#14381

Merged
ermshiperete merged 2 commits intomasterfrom
test/developer/validutf8
Jul 29, 2025
Merged

test(developer): add unit tests for isValidUtf8#14381
ermshiperete merged 2 commits intomasterfrom
test/developer/validutf8

Conversation

@ermshiperete
Copy link
Copy Markdown
Contributor

Follow-up-of: #14369
Test-bot: skip

@keymanapp-test-bot
Copy link
Copy Markdown

User Test Results

Test specification and instructions

User tests are not required

Copy link
Copy Markdown
Member

@mcdurdin mcdurdin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I wonder if we can run this compiler update against the keyboards repo just as another sniff test?

You can do this by building kmcmplib, kmc (and its child modules), and then exporting KMC=node <path-to-kmc's-package.json>, e.g. export KMC="node ~/keyman/developer/src/kmc" or similar.

Co-authored-by: Marc Durdin <marc@durdin.net>
@ermshiperete
Copy link
Copy Markdown
Contributor Author

LGTM. I wonder if we can run this compiler update against the keyboards repo just as another sniff test?

You can do this by building kmcmplib, kmc (and its child modules), and then exporting KMC=node <path-to-kmc's-package.json>, e.g. export KMC="node ~/keyman/developer/src/kmc" or similar.

That did work.

(using tilde didn't work, so the export has to be export KMC="node $HOME/keyman/developer/src/kmc")

@ermshiperete ermshiperete merged commit ce25be1 into master Jul 29, 2025
8 checks passed
@ermshiperete ermshiperete deleted the test/developer/validutf8 branch July 29, 2025 09:33
@github-project-automation github-project-automation bot moved this from Todo to Done in Keyman Jul 29, 2025
@keyman-server
Copy link
Copy Markdown
Collaborator

Changes in this pull request will be available for download in Keyman version 19.0.93-alpha

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

3 participants