Skip to content

maint(common): rename and move node-related script functions into node.inc.sh#14540

Merged
mcdurdin merged 1 commit intomasterfrom
maint/common/move-node-related-functions-out-of-utils.inc.sh-missing-parts
Aug 18, 2025
Merged

maint(common): rename and move node-related script functions into node.inc.sh#14540
mcdurdin merged 1 commit intomasterfrom
maint/common/move-node-related-functions-out-of-utils.inc.sh-missing-parts

Conversation

@Markus-SWAG
Copy link
Copy Markdown
Contributor

@Markus-SWAG Markus-SWAG commented Aug 18, 2025

Consolidates the node-related script functions into node.inc.sh, as part of cleaning up the build scripts and making them easier to maintain into the future. In the earlier commits some changes were missing.

Fixes: #14447
Follows: #14451
Test-bot: skip

…e.inc.sh

    Consolidates the node-related script functions into node.inc.sh, as part
    of cleaning up the build scripts and making them easier to maintain into
    the future. In the earlier commite some changes were missing.

    Fixes: #14447
@Markus-SWAG Markus-SWAG requested a review from mcdurdin August 18, 2025 09:49
@github-project-automation github-project-automation bot moved this to Todo in Keyman Aug 18, 2025
@github-actions github-actions bot added resources/ common/ maint Maintenance work -- continuous integration, build scripts, infrastructure labels Aug 18, 2025
@keymanapp-test-bot keymanapp-test-bot bot added the user-test-missing User tests have not yet been defined for the PR label Aug 18, 2025
@keymanapp-test-bot
Copy link
Copy Markdown

keymanapp-test-bot bot commented Aug 18, 2025

User Test Results

Test specification and instructions

User tests are not required

Test Artifacts

@keymanapp-test-bot keymanapp-test-bot bot added this to the A19S10 milestone Aug 18, 2025
Copy link
Copy Markdown
Member

@mcdurdin mcdurdin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@keymanapp-test-bot keymanapp-test-bot bot removed the user-test-missing User tests have not yet been defined for the PR label Aug 18, 2025
@mcdurdin mcdurdin merged commit c6a043c into master Aug 18, 2025
30 checks passed
@mcdurdin mcdurdin deleted the maint/common/move-node-related-functions-out-of-utils.inc.sh-missing-parts branch August 18, 2025 11:08
@github-project-automation github-project-automation bot moved this from Todo to Done in Keyman Aug 18, 2025
@keyman-server
Copy link
Copy Markdown
Collaborator

Changes in this pull request will be available for download in Keyman version 19.0.101-alpha

Markus-SWAG added a commit that referenced this pull request Aug 20, 2025
…e.inc.sh

        Consolidates the node-related script functions into node.inc.sh, as part
        of cleaning up the build scripts and making them easier to maintain into
        the future. In the earlier commite some changes were missing.

        Follows: #14540
        Fixes: #14447

        Build-bot: skip
        Test-bot: skip
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

common/ maint Maintenance work -- continuous integration, build scripts, infrastructure resources/

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

maint(common): move node-related functions out of utils.inc.sh

3 participants