Skip to content

maint(common): rename and move node-related script functions into node.inc.sh#14568

Merged
Markus-SWAG merged 1 commit intomasterfrom
maint/common/move-node-related-functions-out-of-utils.inc.sh-missing-parts
Aug 21, 2025
Merged

maint(common): rename and move node-related script functions into node.inc.sh#14568
Markus-SWAG merged 1 commit intomasterfrom
maint/common/move-node-related-functions-out-of-utils.inc.sh-missing-parts

Conversation

@Markus-SWAG
Copy link
Copy Markdown
Contributor

@Markus-SWAG Markus-SWAG commented Aug 20, 2025

Consolidates the node-related script functions into node.inc.sh, as part
of cleaning up the build scripts and making them easier to maintain into
the future.

Follows: #14540

Build-bot: skip
Test-bot: skip

…e.inc.sh

        Consolidates the node-related script functions into node.inc.sh, as part
        of cleaning up the build scripts and making them easier to maintain into
        the future. In the earlier commite some changes were missing.

        Follows: #14540
        Fixes: #14447

        Build-bot: skip
        Test-bot: skip
@Markus-SWAG Markus-SWAG requested a review from mcdurdin August 20, 2025 08:49
@github-project-automation github-project-automation bot moved this to Todo in Keyman Aug 20, 2025
@keymanapp-test-bot keymanapp-test-bot bot added the user-test-missing User tests have not yet been defined for the PR label Aug 20, 2025
@keymanapp-test-bot
Copy link
Copy Markdown

keymanapp-test-bot bot commented Aug 20, 2025

User Test Results

Test specification and instructions

User tests are not required

Test Artifacts

@keymanapp-test-bot keymanapp-test-bot bot added this to the A19S10 milestone Aug 20, 2025
@github-actions github-actions bot added resources/ common/ maint Maintenance work -- continuous integration, build scripts, infrastructure labels Aug 20, 2025
Copy link
Copy Markdown
Member

@mcdurdin mcdurdin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

The title should indicate that this is to do with docker only, e.g. maint(resources): source node.inc.sh instead of utils.inc.sh in docker-build.inc.sh

@keymanapp-test-bot keymanapp-test-bot bot removed the user-test-missing User tests have not yet been defined for the PR label Aug 20, 2025
@mcdurdin
Copy link
Copy Markdown
Member

mcdurdin commented Aug 20, 2025

Two process notes:

Copy link
Copy Markdown
Contributor

@ermshiperete ermshiperete left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

The PR and commit titles don't really match what's done in the change though... For example could be something like:

maint(common): adjust to new location of node-related script functions

PR #14451 moved the node-related script functions to `node.inc.sh`. This change
updates the docker-build include to use this new file.

Follows: #14451 
Follows: #14540
Build-bot: skip
Test-bot: skip

It's helpful if the PR and commit titles match the code change since that helps when looking at the git history.

@Markus-SWAG Markus-SWAG merged commit 68b5c34 into master Aug 21, 2025
30 checks passed
@Markus-SWAG Markus-SWAG deleted the maint/common/move-node-related-functions-out-of-utils.inc.sh-missing-parts branch August 21, 2025 09:00
@github-project-automation github-project-automation bot moved this from Todo to Done in Keyman Aug 21, 2025
@keyman-server
Copy link
Copy Markdown
Collaborator

Changes in this pull request will be available for download in Keyman version 19.0.104-alpha

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

common/ maint Maintenance work -- continuous integration, build scripts, infrastructure resources/

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

4 participants