maint(common): rename and move node-related script functions into node.inc.sh#14568
Conversation
User Test ResultsTest specification and instructions User tests are not required Test Artifacts
|
mcdurdin
left a comment
There was a problem hiding this comment.
LGTM
The title should indicate that this is to do with docker only, e.g. maint(resources): source node.inc.sh instead of utils.inc.sh in docker-build.inc.sh
|
Two process notes:
|
ermshiperete
left a comment
There was a problem hiding this comment.
LGTM
The PR and commit titles don't really match what's done in the change though... For example could be something like:
maint(common): adjust to new location of node-related script functions
PR #14451 moved the node-related script functions to `node.inc.sh`. This change
updates the docker-build include to use this new file.
Follows: #14451
Follows: #14540
Build-bot: skip
Test-bot: skip
It's helpful if the PR and commit titles match the code change since that helps when looking at the git history.
|
Changes in this pull request will be available for download in Keyman version 19.0.104-alpha |
Consolidates the node-related script functions into node.inc.sh, as part
of cleaning up the build scripts and making them easier to maintain into
the future.
Follows: #14540
Build-bot: skip
Test-bot: skip