auto: A19S30 merge master into autocorrect 🚂#16049
Open
keyman-server wants to merge 534 commits into
Open
Conversation
Also rename file `utils.ts` to `nestedInstanceOf.ts`. Test-bot: skip
Follow-up-of: #15092 Test-bot: skip
…o-web-core auto: A19S16 merge master into web-core
Build-bot: skip Test-bot: skip
refactor(web): change `preInput` to `SyntheticTextStore` `preInput` always contains a `SyntheticTextStore`, so this change modifies the type of the property so that we don't have to always cast it. Follow-up-of: #15092
Co-authored-by: Marc Durdin <marc@durdin.net>
refactor(web): rename target and mock variables and functions This change renames `target` and `mock` variables that identify a text store. Similarly it renames functions with `Target` in the name. Follow-up-of: #15092
docs(web): add clarifying comment for filename See #15092 (comment) for background. Follow-up-of: #15092
test(web): add unit tests for `nestedInstanceOf` Also rename file `utils.ts` to `nestedInstanceOf.ts`.
refactor(web): simplify `insertText` Getting the textStore was done twice, without the second time changing the result. Additionally, `insertText` in the super class also gets the active text store and returns false if it is not set. This change removes those additional code lines that are not needed. Also adds unit tests for `ContextManager.insertText`, and introduces new type `KeymanInfoPair`. Follow-up-of: #15092
Follow-up-of: #15190 Build-bot: skip Test-bot: skip
Also improve Core Adapter to detect if we're running in a browser or on node.js and load the appropriate km-core module. Follow-up-of: #13993 Test-bot: skip
Test-bot: skip
refactor(web): make core adapter and processor tests headless Also improve Core Adapter to detect if we're running in a browser or on node.js and load the appropriate km-core module. Follow-up-of: #13993
Addresses code review comments. Co-authored-by: Marc Durdin <marc@durdin.net> Test-bot: skip
Plus another unit test. Test-bot: skip
fix(web): add text after last deadkey to context Previously we forgot to add the text after the last deadkey - or any text if didn't have deadkeys. This change fixes this and verifies things with additional unit tests.
This change allows the headless core-adapter and CoreKeyboardProcessor tests to run on Windows. Follow-up-of: #15220 Test-bot: skip
Also use const instead of let in `renderer_core.ts`. Test-bot: skip
…A19S17-merge-master-into-web-core
…o-web-core auto: A19S17 merge master into web-core 🎼
…re/web-core-preflight-replay-15887-renames
…re/web-core-preflight-replay-15888-kbdDetails
…chore/web-core-preflight-replay-15899-15894_test-index
…lay-15986-playwrightreporter maint(web): fix Playwright TC reporter 🍒
…lay-15949-15895_WindowsTc maint(web): fix running web e2e tests on Windows 🎼 🍒
In order to maintain roughly the current build artifact size, strip out the unfinished core integration from what we merge with preflight. Test-bot: skip Build-bot: release:android,ios,developer,web
…lay-15858-squiggles chore(web): fix red squiggles in .ts test files in vscode 🍒
…lay-15856-cleanup refactor(web): cleanup return types in KeymanEngine 🍒
…lay-15887-renames refactor(web): rename variables and parameter names in KeymanEngine 🍒
…lay-15888-kbdDetails refactor(web): use `KeyboardDetails` type 🍒
…lay-15899-15894_test-index chore(web): cleanup `web/src/app/browser/src/test-index.ts` exports 🍒
chore(web): web-core preflight - strip core references
chore: web-core preflight
docs: add note on how to use composer on dockerized websites
keyman-server
added
auto
User Test ResultsTest specification and instructions User tests are not required Test Artifacts
|
keymanapp-test-bot
Bot
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Test-bot: skip
Build-bot: build