chore(android): cleanup font variable names, remove obsolete code#16211
Merged
Conversation
keymanapp-test-bot
Bot
added
the
user-test-missing
User Test ResultsTest specification and instructions User tests are not required |
ermshiperete
force-pushed
the
chore/android/cleanup
branch
from
July 8, 2026 10:26
35ea57f to
f9cb9d0
Compare
This change renames the font variable names so that they match the two conceptual fonts we have. Also remove obsolete code that dealt with the `font` parameter being a JSON object instead of a string containing the font filename. Having the `font` parameter containing a JSON object was legacy code that won't happen with current Keyman versions. Follow-up-of: #16188 Build-bot: release:android
ermshiperete
force-pushed
the
chore/android/cleanup
branch
from
July 8, 2026 12:36
f9cb9d0 to
d0e1649
Compare
ermshiperete
marked this pull request as ready for review
July 8, 2026 12:36
mcdurdin
approved these changes
Jul 9, 2026
mcdurdin
left a comment
mcdurdin
left a comment
Member
There was a problem hiding this comment.
Minor tweaks suggested; LGTM
Co-authored-by: Marc Durdin <marc@durdin.net>
keymanapp-test-bot
Bot
removed
the
user-test-missing
Collaborator
|
Changes in this pull request will be available for download in Keyman version 19.0.257-alpha |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change renames the font variable names so that they match the two conceptual fonts we have. Also remove obsolete code that dealt with the
fontparameter being a JSON object instead of a string containing the font filename. Having thefontparameter containing a JSON object was legacy code that won't happen with current Keyman versions.Follow-up-of: #16188
Build-bot: release:android
Test-bot: skip